Summary: | EmptyWorkspaceHelper does not recreate empty workspace correctly | ||
---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Greg Watson <g.watson> |
Component: | IDE | Assignee: | Platform-UI-Inbox <Platform-UI-Inbox> |
Status: | CLOSED DUPLICATE | QA Contact: | |
Severity: | normal | ||
Priority: | P3 | CC: | Lars.Vogel, ma.becker |
Version: | 4.13 | ||
Target Milestone: | --- | ||
Hardware: | PC | ||
OS: | Mac OS X | ||
See Also: |
https://git.eclipse.org/r/149217 https://git.eclipse.org/r/149218 https://git.eclipse.org/r/149259 https://git.eclipse.org/r/149321 |
||
Whiteboard: | |||
Bug Depends on: | 543746 | ||
Bug Blocks: | 550914 |
Description
Greg Watson
2019-09-09 15:17:26 EDT
Greg, please provide a Gerrit for the fix. New Gerrit change created: https://git.eclipse.org/r/149217 New Gerrit change created: https://git.eclipse.org/r/149218 (In reply to Greg Watson from comment #0) > When switching perspective, EmptyWorkspaceHelper is supposed to recreate the > empty workspace by calling recreateEmptyArea(). However this simply calls > createEmptyArea() which checks if projectWizardActions is null. Since it's > not null (the actions were created by the first call to createEmptyArea()), > the same actions are displayed in the empty workspace. > > To fix, it looks like projectWizardActions should be cleared by > recreateEmptyArea() before calling createEmptyArea() again. Can you provide steps to reproduce this issue? Open IDE with empty workspace to show actions. Switch to a different perspective that has different actions. The original actions will still be displayed. (In reply to Eclipse Genie from comment #3) > New Gerrit change created: https://git.eclipse.org/r/149218 I can't see how this change causes a regression. I see that this test has caused problems in the past, but I don't know what to do here. (In reply to Greg Watson from comment #5) > Open IDE with empty workspace to show actions. Switch to a different > perspective that has different actions. The original actions will still be > displayed. I see. But your change does not fix this completely. I used the navigator view and switched from java perspective to the plug-in dev perspective. This is fine now. But when I now switch back to java it's not correct any more. Can you pls. see how that can be fixed also? New Gerrit change created: https://git.eclipse.org/r/149259 New Gerrit change created: https://git.eclipse.org/r/149321 Can this be merged? (In reply to Greg Watson from comment #10) > Can this be merged? I just retested this with the current master branch. By using the navigator view and switching between java and plug-in development perspective in an empty workspace. I don't see an error here as this was fixed with bug 552374 *** This bug has been marked as a duplicate of bug 552374 *** |