Bug 550350

Summary:	Improve performance of annotation column painting
Product:	[Eclipse Project] Platform	Reporter:	Paul Pazderski <paul-eclipse>
Component:	Text	Assignee:	Paul Pazderski <paul-eclipse>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Lars.Vogel
Version:	4.12
Target Milestone:	4.14 M1
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/148169 https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=ac2adad7a6d0be0fc28293d34900f45781810acd
Whiteboard:
Bug Depends on:
Bug Blocks:	80089, 550209

Description Paul Pazderski

2019-08-22 18:25:52 EDT

The paint method of AnnotationRulerColumn is unnecessary inefficient. More details in the change.

The reason I made this a blocker of bug 80089 is that the slowness increase when the range between min and max used annotation layer increases. In case we allow the user to freely set the annotation layer we can get a serious performance problem. (with the old implementation)


@Lars: yes it is a performance ticket again, but that was pure coincidence! Calling me performance master just raise unnecessary expectations. :D

Comment 1 Eclipse Genie

2019-08-22 18:27:36 EDT

New Gerrit change created: https://git.eclipse.org/r/148169

Comment 2 Lars Vogel

2019-08-23 01:09:44 EDT

Thanks, Paul. I highly appreciated your work in the area of performance.

Comment 3 Eclipse Genie

2019-09-15 14:09:55 EDT

Gerrit change https://git.eclipse.org/r/148169 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=ac2adad7a6d0be0fc28293d34900f45781810acd