Summary: | [GTK] DND from SWT to embbedded AWT frame (SWT_AWT) is broken on Linux | ||
---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Alexander Zakusylo <zakgof> |
Component: | SWT | Assignee: | Nikita Nemkin <nikita> |
Status: | ASSIGNED --- | QA Contact: | Eric Williams <ericwill> |
Severity: | normal | ||
Priority: | P3 | CC: | akurtakov, ericwill, loskutov, nikita, s.davyduik |
Version: | 4.7 | Keywords: | triaged |
Target Milestone: | --- | ||
Hardware: | PC | ||
OS: | Linux | ||
See Also: |
https://bugs.eclipse.org/bugs/show_bug.cgi?id=482318 https://git.eclipse.org/r/144922 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=12688564aa61bc1acdbefae82b591a84767f8dca |
||
Whiteboard: |
Description
Alexander Zakusylo
2019-06-26 04:59:01 EDT
Bug introduced with this commit https://github.com/eclipse/eclipse.platform.swt/commit/2214fda883b89bb4f8ad39483d2e3f9ae1a89294#diff-ab3368475e42eefccd01a40e9f83bb54 (In reply to Oleksandr Zakusylo from comment #1) > Bug introduced with this commit > https://github.com/eclipse/eclipse.platform.swt/commit/ > 2214fda883b89bb4f8ad39483d2e3f9ae1a89294#diff- > ab3368475e42eefccd01a40e9f83bb54 Oleksandr, thanks for reporting/bisecting; do you want to provide a patch? Great bug report, with a snippet and broken commit. I have a patch. Old code called XEmbeddedFrame(handle, supportsXEmbed=true). New code calls XEmbeddedFrame(handle), with supportsXEmbed being false by default. New Gerrit change created: https://git.eclipse.org/r/144922 *** Bug 551303 has been marked as a duplicate of this bug. *** Gerrit change https://git.eclipse.org/r/144922 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=12688564aa61bc1acdbefae82b591a84767f8dca (In reply to Eclipse Genie from comment #6) > Gerrit change https://git.eclipse.org/r/144922 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > ?id=12688564aa61bc1acdbefae82b591a84767f8dca Merged the patch to master as it also fixes bug 550517. I'll keep this ticket open (for now) to look at the warning when dragExit is sent. The main bug here is fixed so we don't need to target this for 4.14. The warnings can be investigated for 4.15. What is left here ? (In reply to Alexander Kurtakov from comment #9) > What is left here ? There are at least two issues with dragging (from my comments on Gerrit): 1) When dragging out of the AWT frame: (SWT:587): Gtk-CRITICAL **: 16:24:35.696: gtk_widget_destroy: assertion 'GTK_IS_WIDGET (widget)' failed 2) Drag exit event is triggered with a delay (need to move the mouse a bit) and the error coincides with drag exit firing. I was testing with WSL+VcXsrv, maybe native Linux won't have those issues. I guess we can close this and open new bugs for the above problems, when/if they are confirmed. Please re-target as required. |