Bug 547772

Summary: [9][build path] improve synchronization of data on different tabs of Java Build Path
Product: [Eclipse Project] JDT Reporter: Stephan Herrmann <stephan.herrmann>
Component: UIAssignee: JDT-UI-Inbox <jdt-ui-inbox>
Status: NEW --- QA Contact:
Severity: enhancement    
Priority: P3 CC: daniel_megert, noopur_gupta
Version: 4.12   
Target Milestone: ---   
Hardware: All   
OS: All   
Whiteboard:
Bug Depends on: 546790    
Bug Blocks:    

Description Stephan Herrmann CLA 2019-05-29 18:27:38 EDT 
Left over from bug 546790:

(In reply to Stephan Herrmann from bug 546790 comment #8)
> Next, I noticed that a jar freshly added to the module path still doesn't
> show up, because for this we need an IPackageFragmentRoot, which hasn't been
> created yet. Current solution: raise a warning:
>   Not all modules could be found. Please consider pressing Apply to
> synchronize.

This obviously isn't ideal.

Still, I'm not sure which is the best solution:

- automatically perform Apply? By this we'd loose the option of a true "Cancel".
  or should we remember the initial configuration so that cancel can *restore* it?

- do we need to invent a new representation for a module that is not yet on the build path? Short of Apply we simply will not have an IModuleDescription :(
Comment 1 Noopur Gupta CLA 2019-05-30 02:59:03 EDT 
It's similar to the "Is modular" dialog. There, after adding an external JAR (and before clicking Apply) if we double-click on the "Is modular" node, we get the dialog "Working on Unapplied changes". We can show a similar dialog with Apply and Cancel when switching to the new tab.
Comment 2 Noopur Gupta CLA 2019-05-30 03:04:48 EDT 
(In reply to Noopur Gupta from comment #1)
> It's similar to the "Is modular" dialog. There, after adding an external JAR
> (and before clicking Apply) if we double-click on the "Is modular" node, we
> get the dialog "Working on Unapplied changes". We can show a similar dialog
> with Apply and Cancel when switching to the new tab.
Similar to Launch Configurations, where changing JRE from modular to non-modular on JRE tab and moving to Dependencies tab shows the dialog.
Comment 3 Noopur Gupta CLA 2020-02-17 00:59:28 EST 
Moving out of 4.15.