Bug 547538

Summary:	[GPG signing] Implement real signing tests
Product:	[Technology] JGit	Reporter:	Thomas Wolf <twolf>
Component:	JGit	Assignee:	Project Inbox <jgit.core-inbox>
Status:	NEW ---	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	gunnar, shashankyadav2007
Version:	5.4	Keywords:	helpwanted
Target Milestone:	---
Hardware:	All
OS:	All
See Also:	https://bugs.eclipse.org/bugs/show_bug.cgi?id=547751
Whiteboard:

Description Thomas Wolf

2019-05-22 02:32:10 EDT

There should be real GPG signing tests, with real GPG (pubring.gpg,secring.gpg) and (pubring.kbx,gnupg/private-keys-v1.d/) setups. The tests should do really signed commits, and verify signatures after the commit.

Comment 1 Shashank Yadav

2019-05-23 03:03:28 EDT

Does the scope of this bug also include implementing a GpgVerifier or should a new bug be opened for this? Currently the commits that fixed https://bugs.eclipse.org/bugs/show_bug.cgi?id=491169 only implement a GpgSigner class.

Comment 2 Thomas Wolf

2019-05-23 03:16:29 EDT

Yes, open a new bug for that. Completely missed that. In that case, the scope of this bug covers only really signing commits, without verifying. Tests for verifying should then be added when the verifier is implemented.

Comment 3 Shashank Yadav

2019-05-29 02:50:58 EDT

I've opened https://bugs.eclipse.org/bugs/show_bug.cgi?id=547751 to track implementation of GPG verification feature. Mentioned this bug as well since the GPG verification libraries would be useful while writing the GPG signing tests.