Summary: | toCamelCase command | ||
---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Mickael Istria <mistria> |
Component: | Text | Assignee: | Platform-Text-Inbox <platform-text-inbox> |
Status: | ASSIGNED --- | QA Contact: | |
Severity: | enhancement | ||
Priority: | P4 | CC: | anabhan57, daniel_megert, Dirk.Steinkamp, loskutov, shahdal3asaal |
Version: | 4.10 | Keywords: | bugday, helpwanted |
Target Milestone: | --- | ||
Hardware: | All | ||
OS: | All | ||
See Also: | https://bugs.eclipse.org/bugs/show_bug.cgi?id=576417 | ||
Whiteboard: |
Description
Mickael Istria
2019-01-08 17:07:37 EST
(In reply to Mickael Istria from comment #0) > So BIRTH_DATE would become birthDate. I doubt the benefit of spending resources for this. (In reply to Dani Megert from comment #1) > I doubt the benefit of spending resources for this. I've seen an interesting demo where this gives a kind of wow-effect. But it's indeed a marginal use-case and it probably shouldn't be taken with high priority compared to other stuff in the backlog. (In reply to Mickael Istria from comment #0) > Just like it's possible to turn text ot upper case or lower case, it would > be nice to provide a command to turn a code to camelCase. > This would for example be convenient for people who copy past some XML > columns name (upper case with some _) to help them turning the symbols into > typical Java identifier. So BIRTH_DATE would become birthDate. Hello, I understand the issue and I want to work on it. Best regards. Have you triex anyedit plugin? https://marketplace.eclipse.org/content/anyedit-tools. It has this and many more... (In reply to Shahd Muhareb from comment #3) > I understand the issue and I want to work on it. Do you need help with that? org.eclipse.ui.workbench.texteditor would be the best place for that. (In reply to Mickael Istria from comment #5) > (In reply to Shahd Muhareb from comment #3) > > I understand the issue and I want to work on it. > > Do you need help with that? > org.eclipse.ui.workbench.texteditor would be the best place for th(In reply to Andrey Loskutov from comment #4) > Have you triex anyedit plugin? > https://marketplace.eclipse.org/content/anyedit-tools. It has this and many > more... No, I don't have. I built text-master on eclipse installer and I opened Case action (In reply to Mickael Istria from comment #5) > (In reply to Shahd Muhareb from comment #3) > > I understand the issue and I want to work on it. > > Do you need help with that? > org.eclipse.ui.workbench.texteditor would be the best place for that. (In reply to Mickael Istria from comment #5) > (In reply to Shahd Muhareb from comment #3) > > I understand the issue and I want to work on it. > > Do you need help with that? > org.eclipse.ui.workbench.texteditor would be the best place for that. Yes, it will be interesting. I have opened ui.texteditor and I think caseAction class will be useful (In reply to Mickael Istria from comment #5) > (In reply to Shahd Muhareb from comment #3) > > I understand the issue and I want to work on it. > > Do you need help with that? > org.eclipse.ui.workbench.texteditor would be the best place for that. Hello, Mickael I don't know where I should assign the shortcut of toCmelCase(). I searched for the shortcut of toUpperCase to help me. But I didn't find it. Please can you help me ?? Best Regards. (In reply to Shahd Muhareb from comment #7) > I searched for the shortcut of toUpperCase to help me. But I didn't find it. According to Window > Preferences > General > Keys, shortcut for "To Upper Case" is Ctrl+Shift+X. Searching for M1+M2+X in plugin.xml files of eclipse.platform.text repo shows it's defined in org.eclipse.ui.workbench.texteditor/plugin.xml:L652. That said, we may not need the shortcut immediately as part of a 1st iteration. Just having the command accessible in Ctrl+3 would already be a good addition even if no shortcut is immediately accessible. (In reply to Mickael Istria from comment #8) > (In reply to Shahd Muhareb from comment #7) > > I searched for the shortcut of toUpperCase to help me. But I didn't find it. > > According to Window > Preferences > General > Keys, shortcut for "To Upper > Case" is Ctrl+Shift+X. Searching for M1+M2+X in plugin.xml files of > eclipse.platform.text repo shows it's defined in > org.eclipse.ui.workbench.texteditor/plugin.xml:L652. > > That said, we may not need the shortcut immediately as part of a 1st > iteration. Just having the command accessible in Ctrl+3 would already be a > good addition even if no shortcut is immediately accessible. ok, thanks. we should add an extension point for the new plug-in ?? I follow this tutorial https://www.vogella.com/tutorials/EclipseExtensionPoint/article.html (In reply to Shahd Muhareb from comment #9) > we should add an extension point for the new plug-in ?? We din't need a new plugin. Just add the command similarly to how the "to upper case" command is added, in the same plugin. (In reply to Mickael Istria from comment #10) > (In reply to Shahd Muhareb from comment #9) > > we should add an extension point for the new plug-in ?? > > We don't need a new plugin. Just add the command similarly to how the "to > upper case" command is added, in the same plugin. but when I added it in the same plugin the shortcut of toCamelCase() is now worked but toUpperCase() doesn't. (In reply to Shahd Muhareb from comment #11) > but when I added it in the same plugin the shortcut of toCamelCase() is now > worked but toUpperCase() doesn't. Is your new toCamelCase command using a different id from the toUpperCase one? Please submit your patch via Gerrit and we can have a look in more details. (In reply to Shahd Muhareb from comment #11) > (In reply to Mickael Istria from comment #10) > > (In reply to Shahd Muhareb from comment #9) > > > we should add an extension point for the new plug-in ?? > > > > We don't need a new plugin. Just add the command similarly to how the "to > > upper case" command is added, in the same plugin. > > but when I added it in the same plugin the shortcut of toCamelCase() is now > worked but toUpperCase() doesn't. it is ready. CTRL+SHIFT+W => toUpperCamelCase() CTRL+SHIFT+Z => toUpperCamelCase() (In reply to Shahd Muhareb from comment #13) > (In reply to Shahd Muhareb from comment #11) > > (In reply to Mickael Istria from comment #10) > > > (In reply to Shahd Muhareb from comment #9) > > > > we should add an extension point for the new plug-in ?? > > > > > > We don't need a new plugin. Just add the command similarly to how the "to > > > upper case" command is added, in the same plugin. > > > > but when I added it in the same plugin the shortcut of toCamelCase() is now > > worked but toUpperCase() doesn't. > > it is ready. > CTRL+SHIFT+W => toUpperCamelCase() > CTRL+SHIFT+Z => toUpperCamelCase() sorry, CTRL+SHIFT+Z => toLowerCamelCase() (In reply to Shahd Muhareb from comment #14) > > it is ready. > > CTRL+SHIFT+W => toUpperCamelCase() > > CTRL+SHIFT+Z => toUpperCamelCase() I don't get it. CamelCaseIsIntentiallyMixingUpperAndLowerCase so why 1 upper and 1 lower case variant? (In reply to Shahd Muhareb from comment #13) > (In reply to Shahd Muhareb from comment #11) > > (In reply to Mickael Istria from comment #10) > > > (In reply to Shahd Muhareb from comment #9) > > > > we should add an extension point for the new plug-in ?? > > > > > > We don't need a new plugin. Just add the command similarly to how the "to > > > upper case" command is added, in the same plugin. > > > > but when I added it in the same plugin the shortcut of toCamelCase() is now > > worked but toUpperCase() doesn't. > > it is ready. > CTRL+SHIFT+W => toUpperCamelCase() > CTRL+SHIFT+Z => toUpperCamelCase() Sorry, CTRL+SHIFT+Z => toLowerCamelCase() (In reply to Mickael Istria from comment #15) > (In reply to Shahd Muhareb from comment #14) > > > it is ready. > > > CTRL+SHIFT+W => toUpperCamelCase() > > > CTRL+SHIFT+Z => toUpperCamelCase() > > I don't get it. CamelCaseIsIntentiallyMixingUpperAndLowerCase so why 1 upper > and 1 lower case variant? Yes, but there are 2 types of Camel case. see that https://en.wikipedia.org/wiki/Camel_case (In reply to Shahd Muhareb from comment #17) > Yes, but there are 2 types of Camel case. > > see that https://en.wikipedia.org/wiki/Camel_case Wow, I didn't realize that and was really happy to learn about CamelCase vs dromedaryCase! So OK with 2 commands, maybe we should label them with the result to clarify them: "To lower camelCase" and "To upper CamelCase". Please submit your patch via gerrit as described in https://wiki.eclipse.org/Gerrit#To_create_a_new_change (In reply to Mickael Istria from comment #18) > (In reply to Shahd Muhareb from comment #17) > > Yes, but there are 2 types of Camel case. > > > > see that https://en.wikipedia.org/wiki/Camel_case > > Wow, I didn't realize that and was really happy to learn about CamelCase vs > dromedaryCase! > So OK with 2 commands, maybe we should label them with the result to clarify > them: "To lower camelCase" and "To upper CamelCase". > Please submit your patch via gerrit as described in > https://wiki.eclipse.org/Gerrit#To_create_a_new_change I still have a problem with submitting over Gerrit. (In reply to Shahd Muhareb from comment #19) > I still have a problem with submitting over Gerrit. If you provide a more precise description of your problem, we may be able to help. (In reply to Mickael Istria from comment #20) > (In reply to Shahd Muhareb from comment #19) > > I still have a problem with submitting over Gerrit. > > If you provide a more precise description of your problem, we may be able to > help. Hello, did you see my submission? I committed my repository from eclipse. but I can't find it in Gerrit. (In reply to Shahd Muhareb from comment #21) > I committed my repository from eclipse. but I can't find it in Gerrit. No. I guess you commit did fail. Please try again and verify the return messages. (In reply to Mickael Istria from comment #20) > (In reply to Shahd Muhareb from comment #19) > > I still have a problem with submitting over Gerrit. > > If you provide a more precise description of your problem, we may be able to > help. Hello, did you see my submission? I committed my repository from eclipse. but I can't find it in Gerrit. (In reply to Shahd Muhareb from comment #23) > Hello, did you see my submission? No. > I committed my repository from eclipse. but I can't find it in Gerrit. What did you try exactly? What were the return messages? possibly duplicate of: https://bugs.eclipse.org/bugs/show_bug.cgi?id=576417 |