Bug 537104

Summary: Table with Detail does not handle readonly and enablement correctly
Product: [Modeling] ECP Reporter: Eugen Neufeld <eneufeld>
Component: EMF FormsAssignee: Lucas Koehler <lkoehler>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: lkoehler
Version: unspecifiedKeywords: test
Target Milestone: 1.18.0   
Hardware: PC   
OS: Linux   
See Also: https://git.eclipse.org/r/126368
https://git.eclipse.org/c/emfclient/org.eclipse.emf.ecp.core.git/commit/?id=35a0d86658706cc4ea80d8bb2c2a6552e9c75a3a
https://git.eclipse.org/r/126555
https://git.eclipse.org/c/emfclient/org.eclipse.emf.ecp.core.git/commit/?id=df3fd96663ef7776d8bafc368ac1cef5a52b6550
Whiteboard:

Description Eugen Neufeld CLA 2018-07-17 06:53:48 EDT 
The detail view of a table with detail must honor the readonly and disabled state of the table control.
Comment 1 Eclipse Genie CLA 2018-07-20 05:38:06 EDT 
New Gerrit change created: https://git.eclipse.org/r/126368
Comment 2 Lucas Koehler CLA 2018-07-20 05:51:17 EDT 
TEST INFORMATION

Summary of the critical part of the change
1. When a table with a detail panel is disabled or set to read only, its detail panel is also set to read only. This mostly leads to controls contained in the detail panel getting disabled.
2. Furthermore, the basic renderer implementation (AbstractSWTRenderer) does no longer disable its SWT controls by default when its VElement is disabled. This behavior must be implemented in sub classes. For all renderers part of EMF Forms this is the case.
3. Remaining renderers were updated to correctly use isEffectivelyReadonly and isEffectivelyEnabled instead of isReadonly and isEnabled.


Potential regressions
1. Details of a disabled/readonly table are no longer editable. This is intended but might not be considered by a client
2. Custom renderers directly extending AbstractSWTRenderer, might no longer have proper disable/readonly behavior
3. Renderers might be disabled/readonly more often than so far if one of their parents is disabled/readonly


Affected areas / use cases
Disabling/Readonly of tables with detail panel and parent elments (e.g. containers) of other controls

Things that shall be tested
That all renderered controls are still disabled/set to readonly as expected. They might be disabled/readonly more often than before (1. & 3.) or not at all anymore if they are not children of AbstractControlSWTRenderer (2.)
Comment 4 Eclipse Genie CLA 2018-07-24 09:39:45 EDT 
New Gerrit change created: https://git.eclipse.org/r/126555