Bug 536794

Summary:	Hybrid pattern matching recognizes SPECIFIC backend requirements only
Product:	[Modeling] Viatra	Reporter:	Gabor Bergmann <gabor.bergmann>
Component:	Query	Assignee:	Project Inbox <viatra-query>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	gabor.bergmann, zoltan.ujhelyi
Version:	2.0.0
Target Milestone:	2.0.1
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/125759 https://git.eclipse.org/c/viatra/org.eclipse.viatra.git/commit/?id=e8087d4f56704274c878db4d53c1cea5e6e64e65 https://git.eclipse.org/r/125982 https://git.eclipse.org/c/viatra/org.eclipse.viatra.git/commit/?id=eb7af47b4f1f55f5dc002a31cc62f4bc405dc0df https://git.eclipse.org/r/126006 https://git.eclipse.org/r/126007 https://git.eclipse.org/c/viatra/org.eclipse.viatra.git/commit/?id=bd9868fcaabef2e8cec89e23acce32d30c2f65ab https://git.eclipse.org/c/viatra/org.eclipse.viatra.git/commit/?id=03d1fb471bbc41b51fc9710d92e9107eeec7f62d
Whiteboard:

Description Gabor Bergmann

2018-07-08 06:30:06 EDT

DontFlattenIncrementalPredicate tries to recognize whether a called pattern should be matched by the incremental backend. Unfortunately, it only considers the case where an explicit backend selection is given (BackendRequirement.SPECIFIC), and does not realize if the PQuery requires the default incremental backend instead. Unfortunately, the latter may be quite usual when a pattern is declared as "incremental pattern" in the VQL.

Comment 1 Eclipse Genie

2018-07-08 07:49:37 EDT

New Gerrit change created: https://git.eclipse.org/r/125759

Comment 2 Zoltan Ujhelyi

2018-07-09 04:51:34 EDT

Good catch. Given this is a regression in 2.0 (caused by an incomplete solution for bug 530519, I propose this as a backport candidate for 2.0.1.

Comment 3 Eclipse Genie

2018-07-09 07:19:01 EDT

Gerrit change https://git.eclipse.org/r/125759 was merged to [master].
Commit: http://git.eclipse.org/c/viatra/org.eclipse.viatra.git/commit/?id=e8087d4f56704274c878db4d53c1cea5e6e64e65

Comment 4 Eclipse Genie

2018-07-12 10:25:04 EDT

New Gerrit change created: https://git.eclipse.org/r/125982

Comment 5 Eclipse Genie

2018-07-13 03:29:10 EDT

Gerrit change https://git.eclipse.org/r/125982 was merged to [master].
Commit: http://git.eclipse.org/c/viatra/org.eclipse.viatra.git/commit/?id=eb7af47b4f1f55f5dc002a31cc62f4bc405dc0df

Comment 6 Eclipse Genie

2018-07-13 03:34:23 EDT

New Gerrit change created: https://git.eclipse.org/r/126006

Comment 7 Eclipse Genie

2018-07-13 03:34:25 EDT

New Gerrit change created: https://git.eclipse.org/r/126007

Comment 8 Eclipse Genie

2018-07-13 05:03:06 EDT

Gerrit change https://git.eclipse.org/r/126007 was merged to [2.0-maintenance].
Commit: http://git.eclipse.org/c/viatra/org.eclipse.viatra.git/commit/?id=bd9868fcaabef2e8cec89e23acce32d30c2f65ab

Comment 9 Eclipse Genie

2018-07-13 05:03:08 EDT

Gerrit change https://git.eclipse.org/r/126006 was merged to [2.0-maintenance].
Commit: http://git.eclipse.org/c/viatra/org.eclipse.viatra.git/commit/?id=03d1fb471bbc41b51fc9710d92e9107eeec7f62d

Comment 10 Zoltan Ujhelyi

2018-07-13 05:12:31 EDT

Fix with corresponding test cases added to master and backported to 2.0-maintenance branch. Closing as fixed.