Bug 536250

Summary:	Non Changeable features can be changed and lead to inconsistent display
Product:	[Modeling] ECP	Reporter:	Eugen Neufeld <eneufeld>
Component:	EMF Forms	Assignee:	Lucas Koehler <lkoehler>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	lkoehler
Version:	unspecified	Keywords:	test
Target Milestone:	1.20.0
Hardware:	PC
OS:	Linux
See Also:	https://git.eclipse.org/r/134388 https://git.eclipse.org/c/emfclient/org.eclipse.emf.ecp.core.git/commit/?id=417236512ab710a39f2427ac1e655bab626db6d6
Whiteboard:

Description Eugen Neufeld

2018-06-25 09:34:25 EDT

If the view model contains a control which is bound to a non changeable feature, then the rendered control should reset its value when it is changed due to the databinding exception being thrown.

Currently this is not the case so that the value being displayed differs from the actual value in the model.

Comment 1 Eugen Neufeld

2018-08-22 09:35:43 EDT

Mass Move due to time constraints

Comment 2 Eugen Neufeld

2018-11-06 04:41:00 EST

Mass move to 1.20 due to time constraints.

Comment 3 Eclipse Genie

2018-12-21 08:17:25 EST

New Gerrit change created: https://git.eclipse.org/r/134388

Comment 4 Eclipse Genie

2019-02-18 11:42:30 EST

Gerrit change https://git.eclipse.org/r/134388 was merged to [develop].
Commit: http://git.eclipse.org/c/emfclient/org.eclipse.emf.ecp.core.git/commit/?id=417236512ab710a39f2427ac1e655bab626db6d6

Comment 5 Lucas Koehler

2019-02-19 02:38:18 EST

TEST INFORMATION
Summary of the critical part of the change
If a structural feature is marked as unchangeable in the ecore model, default renderers will now render is as readonly. Tables and grids still allow to edit elements referenced/contained in their multi reference but they no longer allow to add, remove, or move objects.

Potential regressions
A feature that is marked as unchangeable is no longer editable by the user

Affected areas / use cases
All controls in a rendered form whose rendered features are marked unchangeable in the ecore model.

Things that shall be tested
That all control which should be editable are still editable. Or alternatively, that all features that should be editable are NOT marked unchangeable in the ecore model.