Bugzilla – Full Text Bug Listing
| Summary: | [Dark Theme] Branch label color is too light | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Technology] EGit | Reporter: | Lars Vogel <Lars.Vogel> | ||||||
| Component: | UI | Assignee: | Project Inbox <egit.ui-inbox> | ||||||
| Status: | RESOLVED FIXED | QA Contact: | |||||||
| Severity: | enhancement | ||||||||
| Priority: | P3 | CC: | Lars.Vogel, twolf | ||||||
| Version: | unspecified | Keywords: | usability | ||||||
| Target Milestone: | 5.10 | ||||||||
| Hardware: | PC | ||||||||
| OS: | Linux | ||||||||
| See Also: |
https://git.eclipse.org/r/c/egit/egit/+/168287 https://git.eclipse.org/c/egit/egit.git/commit/?id=68bcb65a9bbaeff880095ca03c76683411806cd9 |
||||||||
| Whiteboard: | |||||||||
| Attachments: |
|
||||||||
Which color? I presume you mean the "other references": HEAD, FETCH_HEAD, ORIG_HEAD, and so on. There are quite a few colors involved; see class SWTPlotRenderer. They're currently all hard-coded, and for each ref type, there are actually two colors: one for the border and one for the fill. And the text color is hard-coded to black. To avoid inconsistencies, one would probably want to use preferences for the fill colors only and derive the border colors automatically, and also automatically choose black or a light gray depending on whether the background is dark or light. With some care, such automatic determination of colors should be possible; we do something similar already for the overview ruler in the DiffEditorPage. (In reply to Thomas Wolf from comment #1) > Which color? I presume you mean the "other references": HEAD, FETCH_HEAD, > ORIG_HEAD, and so on. Yes New Gerrit change created: https://git.eclipse.org/r/c/egit/egit/+/168287 Created attachment 283978 [details]
Screenshot
Way better, thanks Thomas. The remote branches still look too light.
Looks fine IMO, but we can darken those, too. Do you want all these colors be muted/darkened, or just the one for remote branches? (Tags and annotated tags?) (In reply to Thomas Wolf from comment #5) > Looks fine IMO, but we can darken those, too. Do you want all these colors > be muted/darkened, or just the one for remote branches? (Tags and annotated > tags?) All would be the best IMHO (In reply to Thomas Wolf from comment #5) > Looks fine IMO, but we can darken those, too. Do you want all these colors > be muted/darkened, or just the one for remote branches? (Tags and annotated > tags?) The green colour (master) looks already dark enough IMHO Gerrit change https://git.eclipse.org/r/c/egit/egit/+/168287 was merged to [master]. Commit: http://git.eclipse.org/c/egit/egit.git/commit/?id=68bcb65a9bbaeff880095ca03c76683411806cd9 |
Created attachment 274584 [details] Screenshot The branch label color is too light and really sticks out. Could you use a preference for this color and style it in your dark theme?