Bug 535934

Summary:	Code duplication of getSubClasses in EMFUtil and ECPUtil
Product:	[Modeling] ECP	Reporter:	Lucas Koehler <lkoehler>
Component:	Common	Assignee:	Jonas Helming <jhelming>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P5	CC:	eneufeld, jhelming
Version:	unspecified	Keywords:	test
Target Milestone:	1.20.0
Hardware:	PC
OS:	Linux
See Also:	https://git.eclipse.org/r/133299 https://git.eclipse.org/c/emfclient/org.eclipse.emf.ecp.core.git/commit/?id=d02ad1ff67a367740fbe769eb6b4cc5e47f32712
Whiteboard:

Description Lucas Koehler

2018-06-15 05:54:36 EDT

EMFUtil and ECPUtil each have a getSubClasses(EClass) method with their own implementation. This should be single sourced.

Comment 1 Eugen Neufeld

2018-08-22 09:35:45 EDT

Mass Move due to time constraints

Comment 2 Eugen Neufeld

2018-11-06 04:41:02 EST

Mass move to 1.20 due to time constraints.

Comment 3 Jonas Helming

2018-11-30 05:39:35 EST

Testing Information:

The ECPReferenceService will use EMFUtils now. In case a reference points to "EObject", this will allow to create any registered EClass (insetad of "none" before). So in case you are using the ECP application (including projects, etc.) AND you have references to "EObject" in the model, you should validate that this is wanted.

Comment 4 Eclipse Genie

2018-11-30 05:41:23 EST

New Gerrit change created: https://git.eclipse.org/r/133299

Comment 5 Eclipse Genie

2018-12-05 07:54:50 EST

Gerrit change https://git.eclipse.org/r/133299 was merged to [develop].
Commit: http://git.eclipse.org/c/emfclient/org.eclipse.emf.ecp.core.git/commit/?id=d02ad1ff67a367740fbe769eb6b4cc5e47f32712