Bugzilla – Full Text Bug Listing
| Summary: | [regression] Scrollbar area in compare editor too small | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Andrey Loskutov <loskutov> | ||||
| Component: | SWT | Assignee: | Simeon Andreev <simeon.danailov.andreev> | ||||
| Status: | VERIFIED FIXED | QA Contact: | Eric Williams <ericwill> | ||||
| Severity: | major | ||||||
| Priority: | P3 | CC: | ericwill, niraj.modi, platform-swt-inbox, simeon.danailov.andreev, sravankumarl, ulrich.hobelmann | ||||
| Version: | 4.8 | Keywords: | regression, triaged | ||||
| Target Milestone: | 4.8 RC1 | Flags: | ericwill:
review+
|
||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| See Also: |
https://git.eclipse.org/r/122683 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=d6a5bea94a14113a5363a496b62a062bef433a11 |
||||||
| Whiteboard: | |||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 533799 | ||||||
| Attachments: |
|
||||||
This is a regression from bug 533799. Reverting commit a7bdb7b18497c21b22a979c96dbcb5e3458f925d fixes compare editor. We should either revert it or provide a better fix. New Gerrit change created: https://git.eclipse.org/r/122683 Looks like Scrollable.hScrollBarWidth used to return the preferred height of the scrollbar, but due to fix for bug 533799 now returns the width. I've overlooked this during refactoring; should be fine now. I also checked behaviour of snippet for bug 533799 and behaviour of Problems View, no GTK errors are printed on resize of those particular widgets. Note that e.g. a text editor (and maybe other parts) still emit errors when resized too much, likely they need similar handling as done in tree/table for bug 533799. (In reply to Simeon Andreev from comment #3) > Looks like Scrollable.hScrollBarWidth used to return the preferred height of > the scrollbar, but due to fix for bug 533799 now returns the width. > > I've overlooked this during refactoring; should be fine now. > > I also checked behaviour of snippet for bug 533799 and behaviour of Problems > View, no GTK errors are printed on resize of those particular widgets. > > Note that e.g. a text editor (and maybe other parts) still emit errors when > resized too much, likely they need similar handling as done in tree/table > for bug 533799. Last time I worked with scrollbars, this logic messed me up as well. :) I'll review the patch momentarily. Gerrit change https://git.eclipse.org/r/122683 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=d6a5bea94a14113a5363a496b62a062bef433a11 (In reply to Eclipse Genie from comment #5) > Gerrit change https://git.eclipse.org/r/122683 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/ > ?id=d6a5bea94a14113a5363a496b62a062bef433a11 In master now. Thanks for the quick fix Simeon. *** Bug 535025 has been marked as a duplicate of this bug. *** Please verify this fix on latest RC2 Eclipse Build id: I20180523-2000, Thanks! verified in Eclipse SDK Version: Photon (4.8) Build id: I20180524-0900 OS: Linux, v.4.16.10-300.fc28.x86_64, x86_64 / gtk 3.22.30 Java version: 1.8.0_171 |
Created attachment 274044 [details] broken scrollbar area Something must be broken recently in compare editor. Open diff or compare for any file (or just compare two files from any project with each other), and see that the scrollbar is shorter as the editor itself. See attached picture taken on RHEL 7.4 (GTK 3.22) with I20180513-2000. I believe I've seen this is also on Windows, but I have no Windows right now to verify. I've put SWT on CC in case this is SWT issue.