Bug 534154

Comment 1 Lars Vogel 2018-04-27 09:41:57 EDT

Contact David Sommer from https://github.com/davidsommer/iconDecoration/ if you would be intersted in providing a patch.

Comment 2 Mickael Istria 2018-04-27 09:58:31 EDT

I'm not convinced it would be of very high value, as it would only be worth applying for small images that are ok to be previewed in a 16x16 box and if we only apply it to some images and not others, it would feel inconsistent to users. If we want to overcome this inconsistency but still offer the feature, it means the best thing is to have it as an opt-in preference. But features that are hidden in preferences probably reach 5% of our users, so they're usually not so used and then not so worth it.
Moveover, I don't think previewing images in source tree is so necessary in an IDE. VSCode doesn't even show an icon, and I believe other IDEs like IntelliJ don't preview images in icon neither... I don't think such feature is hardly desired and would make a difference.

Comment 3 Lars Vogel 2018-04-27 10:03:47 EDT

If we show reviews for icons, we would show reviews for all icons. I think Davids plug-in scale the resulting image to 16x16.

So inconsistency should not be an issue here, if we do it right.

Comment 4 Mickael Istria 2018-04-27 10:06:17 EDT

(In reply to Lars Vogel from comment #3)
> If we show reviews for icons, we would show reviews for all icons. I think
> Davids plug-in scale the resulting image to 16x16.

I'm eager to see how the splashscreen of Eclipse IDE looks like in a 16x16 box in the project explorer and how much CPU it would take to just browse a folder of icons ;)

Comment 5 Lars Vogel 2018-04-27 10:09:20 EDT

(In reply to Mickael Istria from comment #4)
> (In reply to Lars Vogel from comment #3)
> > If we show reviews for icons, we would show reviews for all icons. I think
> > Davids plug-in scale the resulting image to 16x16.
> 
> I'm eager to see how the splashscreen of Eclipse IDE looks like in a 16x16
> box in the project explorer and 

Very selective example. ;-) Now image how nice a 16x16 icon will look like. :-)


> how much CPU it would take to just browse a
> folder of icons ;)

AFAFIK current implementation is an icon decorator which replace the placeholder icon. And I think these are calculated async.

Comment 6 Mickael Istria 2018-04-27 10:40:35 EDT

(In reply to Lars Vogel from comment #5)
> Very selective example. ;-) Now image how nice a 16x16 icon will look like.
> :-)

Most of the png images I manipulate in the Eclipse IDE these days have been splashscreens ans screenshot for doc/N&N and I believe the proposal would have a negative impact on this kind of work.
IMO, it's only good for icons.

Comment 7 Lars Vogel 2018-04-27 10:57:25 EDT

Created attachment 273845 [details]
Screenshot

(In reply to Mickael Istria from comment #6)
> Most of the png images I manipulate in the Eclipse IDE these days have been
> splashscreens ans screenshot for doc/N&N and I believe the proposal would
> have a negative impact on this kind of work.
> IMO, it's only good for icons.

I (and other like for example Matthias) work a lot with icons, this would hugely improve my current experience. See screenshot

Comment 8 Dani Megert 2018-04-27 13:18:06 EDT

(In reply to Lars Vogel from comment #7)
> Created attachment 273845 [details]
> Screenshot
> 
> (In reply to Mickael Istria from comment #6)
> > Most of the png images I manipulate in the Eclipse IDE these days have been
> > splashscreens ans screenshot for doc/N&N and I believe the proposal would
> > have a negative impact on this kind of work.
> > IMO, it's only good for icons.
> 
> I (and other like for example Matthias) work a lot with icons, this would
> hugely improve my current experience. See screenshot

That screenshot does not really show how useful it would be.

Comment 9 Dani Megert 2018-04-27 13:18:50 EDT

I also think the icons in the views are too small to deliver a usable preview.