Description
Christian Damus
2018-04-23 13:54:41 EDT
New Gerrit change created: https://git.eclipse.org/r/124038 New Gerrit change created: https://git.eclipse.org/r/124105 The idea of the final solution is the following: Instead of using a service which creates a ViewModelContextfor each element in the table we use a less invasive method. The validation process is a two step process. The first step is the actual validation. This is straightforward. The second step is to map the validation results on the actual controls. This is easy for 'normal' controls like strings. For tables we have to decide which settings belong to the table control. This is done by an EMFFormsMappingProvider. The current implementation only adds the setting of the table reference and the settings of the columns. The solution is now to also add all other settings of the entries to the list of settings which belong to the control. Gerrit change https://git.eclipse.org/r/124105 was merged to [develop]. Commit: http://git.eclipse.org/c/emfclient/org.eclipse.emf.ecp.core.git/commit/?id=f2fad625d28b4c37709c643ae408598b6b15ef7a New Gerrit change created: https://git.eclipse.org/r/124417 Gerrit change https://git.eclipse.org/r/124417 was merged to [develop]. Commit: http://git.eclipse.org/c/emfclient/org.eclipse.emf.ecp.core.git/commit/?id=27af07caa5e746fa491c9757383dc3a1b5acec75 New Gerrit change created: https://git.eclipse.org/r/126718 Gerrit change https://git.eclipse.org/r/126718 was merged to [develop]. Commit: http://git.eclipse.org/c/emfclient/org.eclipse.emf.ecp.core.git/commit/?id=491218701d2c8242a5434549b6c8b9efd833320b TEST INFORMATION Summary of the critical part of the change There is now a second plugin which is able to provide the necessary information to show validation messages for tables with detail (org.eclipse.emfforms.core.services.mappingprovider.table.panel). The old plugin org.eclipse.emf.ecp.view.table.validation is not part of the org.eclipse.emf.ecp.view.validation.initial.feature anymore, but can be found on the target update site directly (EMF Forms Table Detail Validation (Legacy)). Potential regressions As we don't create childcontexts anymore, implementations which rely on this may be broken due to missing ViewModelContexts. Affected areas / use cases Validation on tables with detail. Things that shall be tested Validation behavior on tables with detail. Reopening because commit 49121870 causes the development build including the slow tests to fail. Verified with: https://git.eclipse.org/r/#/c/127220/ New Gerrit change created: https://git.eclipse.org/r/127355 Gerrit change https://git.eclipse.org/r/127355 was merged to [develop]. Commit: http://git.eclipse.org/c/emfclient/org.eclipse.emf.ecp.core.git/commit/?id=47c2af720e95209722b9798c65e6a3c263c8534f Mass Move due to time constraints |