Bug 531033

Summary:	Move Color options from Text Editors to the Colors and Fonts preference page
Product:	[Eclipse Project] Platform	Reporter:	Lars Vogel <Lars.Vogel>
Component:	Text	Assignee:	Platform-Text-Inbox <platform-text-inbox>
Status:	NEW ---	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	aobuchow, Lars.Vogel, ma.becker, mistria, thatnitind
Version:	3.7.1	Keywords:	usability
Target Milestone:	---
Hardware:	All
OS:	All
See Also:	https://bugs.eclipse.org/bugs/show_bug.cgi?id=46103 https://bugs.eclipse.org/bugs/show_bug.cgi?id=532359
Whiteboard:
Bug Depends on:	564488
Bug Blocks:

Description Lars Vogel

2018-02-12 05:42:13 EST

IMHO it is currently hard for the user to understand that the colors for the text editor are set in the Text Editors tab. 

I suggest to move them to the Colors and Fonts preference page for consistency.

Comment 1 Lars Vogel

2018-02-12 05:42:47 EST

Mickael/ Matthias WDYT?

Comment 2 Matthias Becker

2018-02-12 06:47:05 EST

so this would be all the colors in "Appearance color options"
I see that for some colors there is an additional "System Default" check box.
How can this be translated to the "Colors & Fonts" page?

When we do this. We have to consider users that have a workspace where they did configure their own colors in the "Text Editors" page. Is there a possibility to migrate the settings from one pref store to another"?

Comment 3 Mickael Istria

2018-02-12 07:48:51 EST

That would be a good change for usability. However, I'm not sure that the colors in Text Editors preference use the same "backend" than the ones in Colors and Fonts preferences. If not, it'd be harder to implement the proposed change.
Also, let's not get rid of the settings  in the Text Editors page immediately. If we're to implement this, I think it's better to first make them available in the Colors and Fonts page (and duplicated), and then consider replacing the legacy UI with a link to the Colors and Fonts page.

Comment 4 Nitin Dahyabhai

2020-09-17 04:53:24 EDT

The appearance set of colors is also settable for other editors, like the Java Editor. What would be the recommendation for them?

Comment 5 Mickael Istria

2020-09-17 04:55:37 EDT

(In reply to Nitin Dahyabhai from comment #4)
> The appearance set of colors is also settable for other editors, like the
> Java Editor. What would be the recommendation for them?

It depends on the complexity of the page; but if it's nothing else than a list of a descriptions/colorr pairs, then the Colors and Fonts page is a better fit IMO.
However, if there are some complex preview or conditions, then the Colors and Fonts page is too limited and sticking to a specific page would be better.