Bug 530391

Summary: Issue with the update of the style of text widgets
Product: [Modeling] EEF Reporter: Stephane Begaudeau <stephane.begaudeau>
Component: User InterfaceAssignee: Laurent Fasani <laurent.fasani>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: laurent.fasani, pierre-charles.david
Version: 2.0.1   
Target Milestone: 2.0.1   
Hardware: All   
OS: All   
See Also: https://git.eclipse.org/r/116123
https://git.eclipse.org/c/eef/org.eclipse.eef.git/commit/?id=b915910cb26d0e7f0f3f62827b30c80602bd842d
Whiteboard:
Attachments:
Description Flags
ODesign showing the issue none

Description Stephane Begaudeau CLA 2018-01-26 11:05:24 EST
Created attachment 272428 [details]
ODesign showing the issue

Steps to reproduce:

- Use a text widget with a style (bold) and a conditional style (italic)
- Use a precondition like self.name.size() > 5

If you change the name of the selected object and type enter, the style should change from bold to italic back and forth depending on the length of the name. It does not work, it just moves from bold to bold+italic. The bold property is not properly removed.



The issue comes front the EEFTextLifecycleManager (as usual) in the method setStyle, we are giving the style helper the current font of the text widget as the default font while the font of the shell would be more relevant instead.
Comment 1 Eclipse Genie CLA 2018-01-26 11:10:25 EST
New Gerrit change created: https://git.eclipse.org/r/116123
Comment 3 Pierre-Charles David CLA 2018-01-29 04:53:29 EST
A patch was merged, I suppose this can be closed? Feel free to reopen if I'm mistaken.
Comment 4 Laurent Fasani CLA 2018-01-31 06:09:02 EST
validating ...
Comment 5 Laurent Fasani CLA 2018-01-31 10:08:34 EST
Validate with Sirius5.1.1rc5