Bug 528388

Summary:	IDE Theme preview needs accessibility work
Product:	[ECD] Orion (Archived)	Reporter:	Carolyn MacLeod <Carolyn_MacLeod>
Component:	Client	Assignee:	Carolyn MacLeod <Carolyn_MacLeod>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	Keywords:	accessibility
Version:	unspecified
Target Milestone:	17.0
Hardware:	PC
OS:	Windows 7
See Also:	https://github.com/eclipse/orion.client/pull/285
Whiteboard:

Description Carolyn MacLeod

2017-12-10 18:34:50 EST

The Theme Preview on the IDE Theme settings page needs accessibility work.
There are duplicate ids, landmarks that shouldn't be there, and the whole thing (from the point of view of a screen reader) needs to be marked up as basically an "interactive" image that shows a preview of the theme.

Comment 1 Eclipse Genie

2017-12-10 18:37:47 EST

GitHub Pull Request 285 created by [carmacleod]
https://github.com/eclipse/orion.client/pull/285

Comment 2 Carolyn MacLeod

2017-12-10 18:39:55 EST

Fixed in PR in comment 1.
Notes:
- made ids unique (deleted those that are not used in preview)
- removed unused elements (i.e. header, file input, slideout panel, dropdown menu panels)
- added missing labels
- localized all label strings
- removed semantics that aren't appropriate in preview (i.e. nav, status)
- updated menu semantics to match current edit page menus
- updated runBar buttons and links to match current edit page
- added desktopmode style to tree to match current
- marked up entire preview as an 'interactive' image within a region
- changed settings.css @import from "../orion/editor/editor.css" (which was an invalid path) to "../edit/edit.css"; (which is needed for the runbar styles)

Note: deleted redundant auxpane id, but needed #auxpane style, so changed rule to .auxpane:not(#leftPane) (because elements that relied on auxpane id also have auxpane class, but leftPane on git page has auxpane class and doesn't want #auxpane style)