Summary: | Concurrent changes can lead to data loss in the text widget | ||
---|---|---|---|
Product: | [Modeling] EEF | Reporter: | Pierre-Charles David <pierre-charles.david> |
Component: | User Interface | Assignee: | Pierre-Charles David <pierre-charles.david> |
Status: | VERIFIED FIXED | QA Contact: | Maxime Porhel <maxime.porhel> |
Severity: | normal | ||
Priority: | P3 | CC: | maxime.porhel, stephane.begaudeau |
Version: | unspecified | ||
Target Milestone: | 2.0.1 | ||
Hardware: | PC | ||
OS: | Linux | ||
See Also: |
https://git.eclipse.org/r/114462 https://git.eclipse.org/c/eef/org.eclipse.eef.git/commit/?id=4f353e1fe5d96da0d32b052ce008d2355f44703c https://git.eclipse.org/r/115394 https://git.eclipse.org/c/eef/org.eclipse.eef.git/commit/?id=0404d254e5e6fda22b6909957a5d6706ee24c270 https://git.eclipse.org/r/116430 https://git.eclipse.org/c/eef/org.eclipse.eef.git/commit/?id=4f2fc626123f8273bbee3911b79637b96611e7e1 https://git.eclipse.org/r/116623 |
||
Whiteboard: |
Description
Pierre-Charles David
2017-12-08 10:09:49 EST
New Gerrit change created: https://git.eclipse.org/r/114462 Gerrit change https://git.eclipse.org/r/114462 was merged to [master]. Commit: http://git.eclipse.org/c/eef/org.eclipse.eef.git/commit/?id=4f353e1fe5d96da0d32b052ce008d2355f44703c New Gerrit change created: https://git.eclipse.org/r/115394 (In reply to Eclipse Genie from comment #3) > New Gerrit change created: https://git.eclipse.org/r/115394 This new patch is for a different, but related case, where: * the user selects and element E; * in its properties view, it starts editing one of E's text properties by typing inside a text widget; * before the user has validated his change (at this time, the new text only exists in the SWT widget), some background job takes a lock on element E; * this lock triggers an update of all the properties widgets to make them read-only (and display a lock); * at this point, the user can neither continue typing nor recover the text he was in the process of editing. The proposed patch detects the situation where a lock it taken while the user is in the process of editing the text, and in this case opens a dialog box which a) explains the situation, and b) offers to copy the text into the system clipboard before it is lost. It's not very satisfying in terms of user interaction but for now I have not found a better way. Gerrit change https://git.eclipse.org/r/115394 was merged to [master]. Commit: http://git.eclipse.org/c/eef/org.eclipse.eef.git/commit/?id=0404d254e5e6fda22b6909957a5d6706ee24c270 Fixed by 0404d254e5e6fda22b6909957a5d6706ee24c270. EEFTextLifecycleManager_textLossByLocking_message should be used as message and not the title in plugins/org.eclipse.eef.ide.ui/src/org/eclipse/eef/ide/ui/internal/widgets/EEFTextLifecycleManager.java Line 514 New Gerrit change created: https://git.eclipse.org/r/116430 Gerrit change https://git.eclipse.org/r/116430 was merged to [master]. Commit: http://git.eclipse.org/c/eef/org.eclipse.eef.git/commit/?id=4f2fc626123f8273bbee3911b79637b96611e7e1 Validated with Sirius 5.1.1 New Gerrit change created: https://git.eclipse.org/r/116623 |