Bug 528192

Summary:	Mark Platform#getJobManager for deletion
Product:	[Eclipse Project] Platform	Reporter:	Lars Vogel <Lars.Vogel>
Component:	UI	Assignee:	Karsten Thoms <karsten.thoms>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	daniel_megert, Lars.Vogel
Version:	3.7.1	Keywords:	api
Target Milestone:	4.8 M6	Flags:	daniel_megert: pmc_approved+ Lars.Vogel: pmc_approved+
Hardware:	PC
OS:	All
See Also:	https://git.eclipse.org/r/117814 https://git.eclipse.org/c/platform/eclipse.platform.runtime.git/commit/?id=68168b31d2f74e46f130e7c787d3b4353d432eb0 https://git.eclipse.org/r/117995 https://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=8527ad494271f82d863ef7433dba73fdae819199
Whiteboard:
Bug Depends on:	528186
Bug Blocks:	531549, 531557, 531559, 564893

Description Lars Vogel

2017-12-06 04:55:08 EST

Once Bug 528186 is fixed, we should mark Platform#getJobManager for deletion for deletion.

See https://wiki.eclipse.org/Eclipse/API_Central/API_Removal_Process

Comment 1 Dani Megert

2017-12-12 04:31:07 EST

+1. It's deprecated for more than 10 years!

Comment 2 Dani Megert

2018-01-31 08:48:24 EST

Please set a target milestone again when you really plan to work on it.

Comment 3 Lars Vogel

2018-02-07 08:03:53 EST

Karsten, can you add the required Javadoc and annotation for M6?

Comment 4 Lars Vogel

2018-02-07 08:04:20 EST

Replacement is Job#getJobManager

Comment 5 Eclipse Genie

2018-02-20 15:37:27 EST

New Gerrit change created: https://git.eclipse.org/r/117814

Comment 6 Dani Megert

2018-02-21 03:40:42 EST

The deletion got announced on the relevant mailing lists.

Comment 7 Eclipse Genie

2018-02-21 03:43:00 EST

Gerrit change https://git.eclipse.org/r/117814 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.runtime.git/commit/?id=68168b31d2f74e46f130e7c787d3b4353d432eb0

Comment 8 Lars Vogel

2018-02-21 03:44:41 EST

Karsten, we also need an entry in our removal document. 

Repo can be found here: https://git.eclipse.org/r/#/admin/projects/platform/eclipse.platform.common

Git path: eclipse.platform.common/bundles/org.eclipse.platform.doc.isv/porting/removals.html

Let me know, if you need help with that.

Comment 9 Karsten Thoms

2018-02-21 04:55:27 EST

I already wondered where to find the guide. Maybe worth to link the guide on the Wiki page [1] at 'add an entry in the porting guide'?

Will get the sources and add the entry soon.

[1] https://wiki.eclipse.org/Eclipse/API_Central/API_Removal_Process

Comment 10 Lars Vogel

2018-02-21 05:00:57 EST

(In reply to Karsten Thoms from comment #9)
> I already wondered where to find the guide. Maybe worth to link the guide on
> the Wiki page [1] at 'add an entry in the porting guide'?
> 
> Will get the sources and add the entry soon.
> 
> [1] https://wiki.eclipse.org/Eclipse/API_Central/API_Removal_Process

+1

Comment 11 Eclipse Genie

2018-02-23 00:23:06 EST

New Gerrit change created: https://git.eclipse.org/r/117995

Comment 12 Eclipse Genie

2018-02-26 11:27:34 EST

Gerrit change https://git.eclipse.org/r/117995 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=8527ad494271f82d863ef7433dba73fdae819199

Comment 13 Karsten Thoms

2018-02-26 11:27:48 EST

Anything left?

Comment 14 Lars Vogel

2018-02-26 12:40:07 EST

Looks good to me, thanks. Only 2 years until we can delete it now.