Bug 525828

Summary:	Splitter needs more accessibility work
Product:	[ECD] Orion (Archived)	Reporter:	Carolyn MacLeod <Carolyn_MacLeod>
Component:	Client	Assignee:	Carolyn MacLeod <Carolyn_MacLeod>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	emoffatt
Version:	unspecified	Keywords:	accessibility
Target Milestone:	17.0
Hardware:	PC
OS:	Windows 7
See Also:	https://github.com/eclipse/orion.client/pull/232
Whiteboard:

Description Carolyn MacLeod

2017-10-10 12:28:26 EDT

As a follow-on to bug 493111 the splitter now needs to have it's semantic markup added: see the aria role, states, and properties section in the aria-practices doc: https://w3c.github.io/aria-practices/#windowsplitter
(The ARIA spec for separator may also be useful: http://w3c.github.io/aria/aria/aria.html#separator)

Specifically, it needs role="separator", aria-valuemin, aria-valuemax,
and aria-valuenow (valuenow is currently there - probably a holdover from the Dojo days - but it is currently being set to NaN which is not useful).
Also, it needs an aria-label (particularly if there are multiple splitters on the page).
Also, vertical splitters need to have aria-orientation="vertical".

Comment 1 Carolyn MacLeod

2017-10-10 12:33:00 EDT

I see that the aria spec says:
The implicit value of aria-valuemin is 0.
The implicit value of aria-valuemax is 100.
So those values do not need to be explicitly set if we are using percentages.
We just need to set the value of aria-valuenow to a percentage number as well.

Comment 2 Eclipse Genie

2017-10-18 16:31:30 EDT

GitHub Pull Request 232 created by [carmacleod]
https://github.com/eclipse/orion.client/pull/232

Comment 3 Carolyn MacLeod

2017-10-18 16:35:32 EDT

Fixed with PR in comment 2. Added role, orientation property, and fixed value property to have percentage instead of NaN.