Bug 521989

Summary:	Save session doesn't work when active editor is not a dialect editor
Product:	[Modeling] Sirius	Reporter:	Minh Tu Ton That <minhtutonthat>
Component:	Core	Assignee:	Project inbox <sirius.core-inbox>
Status:	UNCONFIRMED ---	QA Contact:
Severity:	normal
Priority:	P3	CC:	maxime.porhel, pierre-charles.david
Version:	5.0.0	Keywords:	needinfo
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
See Also:	https://git.eclipse.org/r/104652
Whiteboard:

Description Minh Tu Ton That

2017-09-07 08:16:19 EDT

- Create a Session
- Open a diagram
- Open a text editor
- RightClick on aird on modeling explorer, Save
- Save doesn't work.

Comment 1 Eclipse Genie

2017-09-07 09:02:24 EDT

New Gerrit change created: https://git.eclipse.org/r/104652

Comment 2 Pierre-Charles David

2017-09-14 04:03:32 EDT

I can't reproduce following the given steps. I've tried with both a Modeling Project and a plain one, and saving works. When you saw the problem, were you in a specific context (e.g. Capella) which may have non-default preferences or customizations that could explain the difference?

I'm tempted to accept the patch anyway, because the corresponding code can clearly be made better, but it would be better if we could clarify why you see such a behavior.

Comment 3 Minh Tu Ton That

2017-09-14 07:18:11 EDT

In fact, the use case I provided is just what I deduced from Capella. In Capella we have a Project Explorer view and an Activity Explorer view. We had to override the SaveSession of Sirius to make the save works when there's no diagram opened and Activity Explorer opened.

Comment 4 Maxime Porhel

2017-10-18 03:49:23 EDT

Hi Minh Tu, 

Did you solve your issue in Capella (master for 1.2.0) ?