Summary: | NullPointerException in TrimPaneLayout.setCursor | ||
---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | EPP Error Reports <error-reports-inbox> |
Component: | UI | Assignee: | Karsten Thoms <karsten.thoms> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P3 | CC: | daniel_megert, eclipse, karsten.thoms, loskutov, mistria |
Version: | 4.7 | ||
Target Milestone: | 4.7.3a | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://git.eclipse.org/r/103791 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=518e43234208de721f369d3e0e25ee42c04f83a0 https://git.eclipse.org/r/104637 https://git.eclipse.org/r/104692 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=ee12c0b41ec26bdb9941c174ec55109c1ec73779 |
||
Whiteboard: |
Description
EPP Error Reports
2017-08-28 17:37:34 EDT
The instance variables of type Rectangle are initialized by layout(), but it seems that mouseMove() is called before layout() was called. I don't know how this can be reproduced, but initializing the variables with an empty Rectangle (0,0,0,0) should be valid. The contains() checks will yield false and nothing harmful happens. New Gerrit change created: https://git.eclipse.org/r/103791 see also https://dev.eclipse.org/recommenders/committers/aeri/v2/#!/problems/54c4ef00bee810030da065cd Gerrit change https://git.eclipse.org/r/103791 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=518e43234208de721f369d3e0e25ee42c04f83a0 (In reply to Eclipse Genie from comment #4) > Gerrit change https://git.eclipse.org/r/103791 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/ > ?id=518e43234208de721f369d3e0e25ee42c04f83a0 Thanks Karsten! Can you please also prepare the patch for 4.7.3 ? New Gerrit change created: https://git.eclipse.org/r/104637 New Gerrit change created: https://git.eclipse.org/r/104692 Gerrit change https://git.eclipse.org/r/104692 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=ee12c0b41ec26bdb9941c174ec55109c1ec73779 (In reply to Karsten Thoms from comment #1) > The instance variables of type Rectangle are initialized by layout(), but it > seems that mouseMove() is called before layout() was called. > > I don't know how this can be reproduced, but initializing the variables with > an empty Rectangle (0,0,0,0) should be valid. The contains() checks will > yield false and nothing harmful happens. The stack trace is: java.lang.NullPointerException: null at org.eclipse.e4.ui.workbench.addons.minmax.TrimPaneLayout.setCursor(TrimPaneLayout.java:205) In which version of Eclipse did you check line 205? I looked back and it did not match code that uses those variables. I did not look for line 205. You can look at different incidents of the same problem and they will show the Eclipse version. Then I look at that versions of the file. e.g. https://dev.eclipse.org/recommenders/committers/aeri/v2/#!/incidents/5a0532ebe4b02aaf8b1f1e58 TrimPaneLayout.java:197, Eclipse 4.7.1 https://dev.eclipse.org/recommenders/committers/aeri/v2/#!/incidents/5a0a6688e4b02aaf8b1f8af2 TrimPaneLayout.java:194, Eclipse 4.6.3 Searching for the version that has the error in #205 is showing me commits 27450d6149b3db65988e0c0dd60f3ea6768e6b9c 1458ecfaf64b0467137ffd7ec2f735e6292e5bf9 (In reply to Karsten Thoms from comment #10) > I did not look for line 205. You can look at different incidents of the same > problem and they will show the Eclipse version. Then I look at that versions > of the file. > > e.g. > https://dev.eclipse.org/recommenders/committers/aeri/v2/#!/incidents/5a0532ebe4b02aaf8b1f1e58 > > TrimPaneLayout.java:197, Eclipse 4.7.1 > > https://dev.eclipse.org/recommenders/committers/aeri/v2/#!/incidents/5a0a6688e4b02aaf8b1f8af2 > > TrimPaneLayout.java:194, Eclipse 4.6.3 > > > Searching for the version that has the error in #205 is showing me > commits > 27450d6149b3db65988e0c0dd60f3ea6768e6b9c > 1458ecfaf64b0467137ffd7ec2f735e6292e5bf9 So, looks like this bug report is from a very old version. Yes, the specific incident is from a 3 year old version, and the bug existed from its very first version 7 years ago. When you create a bug report from AERI, *one* incident is picked for the report, but many incidents are attached to the problem report. The actual incident in the problem report is just an indicator, but I find much value in looking at the incidents of the problem. *** Bug 394512 has been marked as a duplicate of this bug. *** The AERI report does not have incidents with platform > 4.7.3, while still collecting incidents for older platform versions. So I assume we can call this fixed for 4.7.3. *** Bug 447011 has been marked as a duplicate of this bug. *** |