Bug 520948

Summary:	[Tests] [GTK] Increase color test coverage in SWT
Product:	[Eclipse Project] Platform	Reporter:	Eric Williams <ericwill>
Component:	SWT	Assignee:	Platform-SWT-Inbox <platform-swt-inbox>
Status:	NEW ---	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	akurtakov
Version:	4.8	Keywords:	bugday, test, triaged
Target Milestone:	---
Hardware:	PC
OS:	Linux
See Also:	https://git.eclipse.org/r/103118 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=334287a185703d8952c40a064bec69d21e3f7961 https://git.eclipse.org/r/103197 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=ea429693630812722e09cb9ae700db050182f6f5
Whiteboard:

Description Eric Williams

2017-08-14 10:55:24 EDT

There are some widgets in SWT that have multiple modes/styles. For example, Buttons have SWT.PUSH, SWT.CHECK, SWT.RADIO, etc.

Some of these widgets have different internal background/foreground machinery depending on the style. At the moment these cases aren't tested very thoroughly which lead to potential test failures in higher level projects (Platform UI, for instance).

For this bug I also plan to add some GTK specific test suites. For example testing selection color -- not supported by SWT API but still testable using some GTK calls.

Comment 1 Eclipse Genie

2017-08-15 15:35:47 EDT

New Gerrit change created: https://git.eclipse.org/r/103118

Comment 2 Eclipse Genie

2017-08-15 16:28:51 EDT

Gerrit change https://git.eclipse.org/r/103118 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=334287a185703d8952c40a064bec69d21e3f7961

Comment 3 Eric Williams

2017-08-15 16:32:48 EDT

(In reply to Eclipse Genie from comment #2)
> Gerrit change https://git.eclipse.org/r/103118 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=334287a185703d8952c40a064bec69d21e3f7961

This adds the test cases for Combo. DateTime is still remaining.

GTK specific tests will follow after that.

Comment 4 Eclipse Genie

2017-08-16 15:51:19 EDT

New Gerrit change created: https://git.eclipse.org/r/103197

Comment 5 Eclipse Genie

2017-08-16 17:08:47 EDT

Gerrit change https://git.eclipse.org/r/103197 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=ea429693630812722e09cb9ae700db050182f6f5

Comment 6 Eric Williams

2017-08-16 17:09:21 EDT

(In reply to Eclipse Genie from comment #5)
> Gerrit change https://git.eclipse.org/r/103197 was merged to [master].
> Commit:
> http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/
> ?id=ea429693630812722e09cb9ae700db050182f6f5

DateTime cases merged. GTK specific tests to follow.

Comment 7 Alexander Kurtakov

2017-12-14 18:01:16 EST

Eric, is this one still relevant? What's going on here?

Comment 8 Eric Williams

2017-12-15 09:00:30 EST

(In reply to Alexander Kurtakov from comment #7)
> Eric, is this one still relevant? What's going on here?

I still have plans for some more tests to be added as JUnits and as platform specific tests. But they are low priority at the moment.

Comment 9 Alexander Kurtakov

2018-07-13 05:04:27 EDT

Maybe Xi can take this one?

Comment 10 Eric Williams

2018-07-13 10:14:31 EDT

(In reply to Alexander Kurtakov from comment #9)
> Maybe Xi can take this one?

Sure. The goal here is to create some platform specific JUnit tests that parse GTK CSS somehow and check things which SWT has no API for, like selection bg color, etc.

Comment 11 Alexander Kurtakov

2018-11-15 07:59:48 EST

Xi, Eric, Is there smth still pending here?

Comment 12 Eric Williams

2018-11-15 08:24:37 EST

(In reply to Alexander Kurtakov from comment #11)
> Xi, Eric, Is there smth still pending here?

Yes but it's not high priority, more just a little side task to improve some test coverage.