Bug 519988

Summary: Use varargs in invocations of DropTarget.setTransfer
Product: [Eclipse Project] PDE Reporter: Lars Vogel <Lars.Vogel>
Component: UIAssignee: Lars Vogel <Lars.Vogel>
Status: VERIFIED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: fabian.pfaff, Lars.Vogel, Vikas.Chandra
Version: 4.7Keywords: bugday, helpwanted
Target Milestone: 4.9 M2   
Hardware: PC   
OS: Linux   
See Also: https://git.eclipse.org/r/125148
https://git.eclipse.org/c/pde/eclipse.pde.ui.git/commit/?id=9b2c83e84b3a6f918d7d02abc289d00a5866fc78
Whiteboard:

Description Lars Vogel CLA 2017-07-21 04:42:41 EDT
See RepositoryReferenceSection.

target.setTransfer(new Transfer[] {URLTransfer.getInstance(), FileTransfer.getInstance()}); can be simplified to

target.setTransfer(URLTransfer.getInstance(), FileTransfer.getInstance());

In this bug you should search for similar usage and replace them all in PDE.

Please upload changes which contain ~10-20 classes to make review easier.
Comment 1 Vikas Chandra CLA 2018-03-13 04:49:01 EDT
Moving out of 4.8.

If you plan for 4.8, please triage back to 4.8 with a patch.
Comment 2 Eclipse Genie CLA 2018-06-28 04:21:27 EDT
New Gerrit change created: https://git.eclipse.org/r/125148
Comment 3 Lars Vogel CLA 2018-06-28 05:59:49 EDT
For cleanup we do not need bug reports anymore, so followup work will be done without bug reference.
Comment 5 Vikas Chandra CLA 2018-07-31 09:55:22 EDT
verified by code inspection