Bug 519652

Summary: [find/replace] No matches to replace message dialog should use verbs (Close) instead of OK
Product: [Eclipse Project] JDT Reporter: Lars Vogel <Lars.Vogel>
Component: UIAssignee: David Weiser <david.eclipse000>
Status: NEW --- QA Contact:
Severity: enhancement    
Priority: P3 CC: david.eclipse000, Lars.Vogel, mistria, noopur_gupta
Version: 4.8Keywords: bugday, helpwanted, usability
Target Milestone: ---   
Hardware: PC   
OS: All   
See Also: https://git.eclipse.org/r/105857
Whiteboard:

Description Lars Vogel CLA 2017-07-13 13:32:41 EDT 

    


    


      



        
          Comment 1
        

        
          Lars Vogel CLA

        

        
        

        
          2017-07-27 06:53:14 EDT
        

      






David, can you have a look for M2?

To validate:
1.) Ctrl+H
2.) Enter a nonsense string, e.g., AKdskfasdfk
3.) Press replace -> Dialog is shown

    


    


      



        
          Comment 2
        

        
          Mickael Istria CLA

        

        
        

        
          2017-09-11 05:34:50 EDT
        

      






Missed 4.8.M2 as code-freeze is today. I've removed target milestone as I didn't see much activity on this issue that would suggest it is targeted for M3. If someone wishes to work on it, please set the target milestone according to your availability to work on this issue.

    


    


      



        
          Comment 3
        

        
          Lars Vogel CLA

        

        
        

        
          2017-09-11 06:01:14 EDT
        

      






David, please take this for M3 (starts after this week).

    


    


      



        
          Comment 4
        

        
          Eclipse Genie CLA

        

        
        

        
          2017-09-27 09:29:33 EDT
        

      






New Gerrit change created: https://git.eclipse.org/r/105857

    


    


      



        
          Comment 5
        

        
          Noopur Gupta CLA

        

        
        

        
          2017-10-17 06:24:15 EDT
        

      






The location where the change is made is used for all other refactoring operations also. Please confirm if the new button label is applicable to other messages as well.