Bug 516532

Summary:

Run configuration has changed dialog should use verbs

Product:

[Eclipse Project] Platform

Reporter:

Lars Vogel <Lars.Vogel>

Component:

Debug

Assignee:

Fabian Pfaff <fabian.pfaff>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

Lars.Vogel, sarika.sinha

Version:

4.7

Keywords:

bugday, helpwanted

Target Milestone:

4.8 M2

Hardware:

OS:

All

See Also:

https://git.eclipse.org/r/98594
https://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=fa2b847f155ce5cc60fac6a40a39aae766823467

Whiteboard:

Attachments:

Description	Flags
Screenshot	none
Discard Changes before	none
Discard Changes after	none

Description Lars Vogel

2017-05-11 15:24:27 EDT

Comment 1 Lars Vogel

2017-05-11 15:25:11 EDT

Created attachment 268293 [details]
Screenshot

Comment 2 Lars Vogel

2017-05-11 15:26:21 EDT

Fabian, please have a look.

Comment 3 Eclipse Genie

2017-06-03 22:39:21 EDT

New Gerrit change created: https://git.eclipse.org/r/98594

Comment 4 Lars Vogel

2017-07-20 06:46:45 EDT

Steps to reproduce:

1.) Open an existing run configuration
2.) Change it without saving
3.) Switch to a new one -> trigger dialog

Comment 5 Sarika Sinha

2017-07-20 06:58:35 EDT

(In reply to Lars Vogel from comment #4)
> Steps to reproduce:
> 
> 1.) Open an existing run configuration
> 2.) Change it without saving
> 3.) Switch to a new one -> trigger dialog

Thanks Lars, I understand this scenario and the gerrit has changed from Yes to Save.
But I see the code change for one more scenario where the Dialog should use the verb as "Discard" . Can I get the steps for that ?

Comment 6 Lars Vogel

2017-07-20 07:59:17 EDT

(In reply to Sarika Sinha from comment #5)
> But I see the code change for one more scenario where the Dialog should use
> the verb as "Discard" . Can I get the steps for that ?

I'm also unable to trigger this dialog. Maybe dead code?

Comment 7 Sarika Sinha

2017-07-27 05:24:50 EDT

Moving to M2.

Comment 8 Fabian Pfaff

2017-08-01 09:57:04 EDT

Created attachment 269628 [details]
Discard Changes before

Comment 9 Fabian Pfaff

2017-08-01 09:57:24 EDT

Created attachment 269629 [details]
Discard Changes after

Comment 10 Sarika Sinha

2017-08-03 00:48:28 EDT

Thanks Fabian for providing the steps and spending time on this. Will release next week after M1 is done.

Comment 11 Eclipse Genie

2017-09-07 08:42:21 EDT

Gerrit change https://git.eclipse.org/r/98594 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.debug.git/commit/?id=fa2b847f155ce5cc60fac6a40a39aae766823467

Comment 12 Lars Vogel

2017-09-07 08:42:46 EDT

Thanks, Fabian.

Comment 13 Sarika Sinha

2017-09-14 07:03:41 EDT

Eclipse SDK
Version: Photon (4.8)
Build id: I20170913-2000
OS: Windows 7, v.6.1, x86_64 / win32