Bug 513256

Summary:	[css][lint] Turn down severities on obnoxious csslint rules
Product:	[ECD] Orion (Archived)	Reporter:	Curtis Windatt <curtis.windatt.public>
Component:	JS Tools	Assignee:	Curtis Windatt <curtis.windatt.public>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P1	CC:	Michael_Rennie
Version:	13.0	Flags:	Michael_Rennie: review+
Target Milestone:	14.0
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Curtis Windatt

2017-03-07 11:11:44 EST

Opening many of our CSS files results in a sea of blue that makes it impossible to see what is actually wrong in the file. For 14.0 we should look at turning down the severity of these issues (to ignore). Longer term we can improve messages and fixes (see Bug 513250).

The highest priority is adjoining classes, which is only an issue in IE6 and we use them frequently in our theme CSS.

Comment 1 Curtis Windatt

2017-03-07 12:20:50 EST

I added a number of things we should change to Bug 513250. There is a lot of controversy over using ids in selectors, but the reason for the rule is still relevent.

adjoining classes rule is not relevent anymore and should be set to ignore.

Comment 2 Curtis Windatt

2017-03-07 12:27:13 EST

All the box model problems are just reminding you that borders and padding affect the final display size. I'm going to reduce this to ignore as well.

Comment 3 Curtis Windatt

2017-03-07 14:18:51 EST

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=9b722f53a45086ce8a5ed5528b26342b68d7e928
Pushed fix to master

Mike, please verify.

Comment 4 Michael Rennie

2017-03-08 12:06:13 EST

Looks good - working in large(ish) CSS files is much less painful now.