Bug 511369

Summary:	[ltk] RefactoringWizardDialog2 dialog should use descriptive verbs instead of "OK"
Product:	[Eclipse Project] JDT	Reporter:	Lars Vogel <Lars.Vogel>
Component:	UI	Assignee:	David Weiser <david.eclipse000>
Status:	ASSIGNED ---	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	daniel_megert, david.eclipse000, Lars.Vogel, noopur_gupta
Version:	4.7	Keywords:	api
Target Milestone:	---
Hardware:	PC
OS:	All
See Also:	https://git.eclipse.org/r/90058
Whiteboard:

Description Lars Vogel

2017-01-31 06:53:40 EST

See Bug 496246.

Dialog in question is RefactoringWizardDialog2.

Comment 1 Lars Vogel

2017-01-31 07:14:20 EST

David, please provide a Gerrit review for the change.

Comment 2 Eclipse Genie

2017-02-01 07:00:23 EST

New Gerrit change created: https://git.eclipse.org/r/90058

Comment 3 David Weiser

2017-02-01 07:06:03 EST

I did not change the label when a yesNo-Dialog is explicitly requested. I think that would not be expected by the user, but just leave a comment if I should.

Comment 4 Lars Vogel

2017-02-09 10:41:38 EST

(In reply to Eclipse Genie from comment #2)
> New Gerrit change created: https://git.eclipse.org/r/90058

The refactoring wizard is not only used for deletion. Might be hard to find a general fitting solution. @David, I suggest to avoid working on this issue for now.

Comment 5 Lars Vogel

2017-05-30 16:51:44 EDT

(In reply to Lars Vogel from comment #4)
> (In reply to Eclipse Genie from comment #2)
> > New Gerrit change created: https://git.eclipse.org/r/90058
> 
> The refactoring wizard is not only used for deletion. Might be hard to find
> a general fitting solution. @David, I suggest to avoid working on this issue
> for now.

The title of the dialog is already set a correct string, e.g., "Deletion" in the case of a deletion. Maybe we can use the same approach for the "OK" button?

Comment 6 David Weiser

2017-07-17 13:35:59 EDT

(In reply to Lars Vogel from comment #5)
> (In reply to Lars Vogel from comment #4)
> > (In reply to Eclipse Genie from comment #2)
> > > New Gerrit change created: https://git.eclipse.org/r/90058
> > 
> > The refactoring wizard is not only used for deletion. Might be hard to find
> > a general fitting solution. @David, I suggest to avoid working on this issue
> > for now.
> 
> The title of the dialog is already set a correct string, e.g., "Deletion" in
> the case of a deletion. Maybe we can use the same approach for the "OK"
> button?

If I am correct, this is already done. In RefactoringWizardDialog2 the ok button label is retrieved from the provided wizard. In case of the DeleteWizard the button is set to "Delete", otherwise the default ok button is used.

Comment 7 Noopur Gupta

2018-04-17 07:29:13 EDT

The attached patch adds new APIs in RefactoringWizard. Moving out of 4.8. 

(In reply to Lars Vogel from comment #4)
> The refactoring wizard is not only used for deletion. Might be hard to find
> a general fitting solution. @David, I suggest to avoid working on this issue
> for now.
If this is handled, please update the patch for the next release.