Bug 510694

Summary:	[Webkit2] Implement 'close' for webkit2
Product:	[Eclipse Project] Platform	Reporter:	Leo Ufimtsev <lufimtse>
Component:	SWT	Assignee:	Leo Ufimtsev <lufimtse>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	error-reports-inbox
Version:	4.7
Target Milestone:	---
Hardware:	PC
OS:	Linux
See Also:	https://git.eclipse.org/r/89116 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=55c14bca06b1ecc75a3d40b628a638279abefc67 https://git.eclipse.org/r/90772 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=4d2e2fc636f3ca7bacfaa9b2aae251065f3683d0 https://git.eclipse.org/r/93574 https://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=05e12c4ca5380f899b620a93da7a82e6132c1cc7 https://bugs.eclipse.org/bugs/show_bug.cgi?id=564911
Whiteboard:
Bug Depends on:	508217, 512001
Bug Blocks:	510183

Description Leo Ufimtsev

2017-01-19 10:01:10 EST

Currently if 'close' is invoked on Webkit2, eclipse hangs on executing the javascript.

This is because webkit1-specific javascript is being executed in WebKit.java:close(), which is causing an infinite loop.

This bug is to work on this port.

Browser.function is required to implement this functionality. Pending till Browser.function is implemented in Webkit2.

Comment 1 Leo Ufimtsev

2017-01-19 10:13:17 EST

Note to self:
- This functionality is used by Javadoc hover. See: Bug 510183

Comment 2 Eclipse Genie

2017-01-19 10:16:20 EST

New Gerrit change created: https://git.eclipse.org/r/89116

Comment 3 Eclipse Genie

2017-01-19 13:00:41 EST

Gerrit change https://git.eclipse.org/r/89116 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=55c14bca06b1ecc75a3d40b628a638279abefc67

Comment 4 Leo Ufimtsev

2017-01-30 11:09:35 EST

After investigation, I found that Browser.close() works on webkit2. The hang was a corner cases where evaluate() was called from within a webkit2 signal, which caused a deadlock. 

I implemented a solution to overcome the deadlock in Bug 510183. (which also re-enabled the close() method. 

As such, this issue is resolved once that patch is merged:
https://git.eclipse.org/r/#/c/89875

Comment 5 Leo Ufimtsev

2017-02-02 11:25:04 EST

Actually, Let me keep this bug open until relevant patches were merged. Will followup later.

Comment 6 Eclipse Genie

2017-02-09 14:56:12 EST

New Gerrit change created: https://git.eclipse.org/r/90772

Comment 7 Leo Ufimtsev

2017-02-14 09:43:44 EST

Awaiting evaluate() logic to move to java #512001

Comment 8 Eclipse Genie

2017-02-15 14:16:57 EST

Gerrit change https://git.eclipse.org/r/90772 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=4d2e2fc636f3ca7bacfaa9b2aae251065f3683d0

Comment 9 Eclipse Genie

2017-03-21 16:39:53 EDT

New Gerrit change created: https://git.eclipse.org/r/93574

Comment 10 Eclipse Genie

2017-03-29 10:46:05 EDT

Gerrit change https://git.eclipse.org/r/93574 was merged to [master].
Commit: http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=05e12c4ca5380f899b620a93da7a82e6132c1cc7

Comment 11 Alexander Kurtakov

2017-06-01 14:04:16 EDT

*** Bug 517623 has been marked as a duplicate of this bug. ***