Summary: | [Generic editor] to provide a way to opt-out irrelevant presentation reconcilers | ||
---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Mickael Istria <mistria> |
Component: | Text | Assignee: | Mickael Istria <mistria> |
Status: | CLOSED WONTFIX | QA Contact: | |
Severity: | enhancement | ||
Priority: | P3 | CC: | daniel_megert, gautier.desaintmartinlacaze, lbullen, mistria, nobody |
Version: | 4.6 | ||
Target Milestone: | 4.8 M2 | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://bugs.eclipse.org/bugs/show_bug.cgi?id=514979 https://git.eclipse.org/r/102624 https://bugs.eclipse.org/bugs/show_bug.cgi?id=520685 |
||
Whiteboard: | |||
Bug Depends on: | |||
Bug Blocks: | 507753 |
Description
Mickael Istria
2016-11-18 10:53:17 EST
I believe bug 514979 would allow to cover the user-story in a more elegant and consistent manner. New Gerrit change created: https://git.eclipse.org/r/102624 (In reply to Eclipse Genie from comment #2) > New Gerrit change created: https://git.eclipse.org/r/102624 The strategy implemented here is that a PresentationReconciler can "opt-out" from binding to Generic Editor by throwing an IllegalArgumentError during `install`. For example, a reconciler that needs to check things dynamically against current editor instance or document to evaluate whether they're useful or not can send the IllegalArgumentError so the Generic Editor will ignore it and try another registered one. As part of this change, we should sort presentationReconcilers by "specialization" ie we sort the provided reconciler extensions by most specialized content-type first. The proposed patch seems to introduce an issue. It seems like bug 520685 can cover the same user-story better. So let's focus on bug 520685 and then re-evaluate whether we need it. Let's abandon this one bug 520685 and related patch covers the initial user story with a cleaner solution. |