Bug 506800

Summary:	Git "filter" (funnel) button needs accessibility work
Product:	[ECD] Orion (Archived)	Reporter:	Carolyn MacLeod <Carolyn_MacLeod>
Component:	Git	Assignee:	Silenio Quarti <Silenio_Quarti>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	Keywords:	accessibility
Version:	unspecified
Target Milestone:	20.0
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Carolyn MacLeod

2016-10-31 12:55:01 EDT

Currently, the git filter is a command button that opens a section that has an invisible section header (commitFilterSection). It might make more sense to make this the same as the git settings (wrench) button, which is a section.
It would inherit more semantically correct expand/collapse markup, and use fewer elements.
(Not sure what it would lose by not being a command).

Comment 1 Carolyn MacLeod

2017-09-05 18:49:37 EDT

The current implementation has very strange keyboard behavior. Give focus to the filter, type space or enter to open the panel, and then start typing the tab key. The next element in the focus ring is the train tracks button, and then the branch switch, and then the Sync button. This is unexpected.
Instead, we need to give focus to the initial field (Message) after the panel is opened (similar to the way a dialog behaves).

Comment 2 Michael Rennie

2018-04-09 09:36:30 EDT

Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. 

For more details see: https://dev.eclipse.org/mhonarc/lists/orion-dev/msg04114.html

Comment 3 Carolyn MacLeod

2019-03-21 14:35:56 EDT

This was fixed as part of recent accessibility work.