Bug 501411

Summary:	Make KeyCodes used for interaction configurable via bindings.
Product:	[Tools] GEF	Reporter:	Matthias Wienand <matthias.wienand>
Component:	GEF MVC	Assignee:	gef-inbox <gef-inbox>
Status:	NEW ---	QA Contact:
Severity:	normal
Priority:	P3
Version:	1.0.0
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:

Description Matthias Wienand

2016-09-14 05:42:23 EDT

Currently, the IFXOnTypePolicy implementations define methods to determine if a KeyEvent is to be processed by the policy. Therefore, in order to change the KeyCode that is associated with the action, one needs to subclass the policy and overwrite the respective method. This should be simplified by specifying the KeyCodes for the policies via bindings.

Comment 1 Matthias Wienand

2017-04-03 10:58:37 EDT

This could be achieved by performing assisted injection of the relevant handlers, so that a delegate can decide if a given input event should trigger a specific action. For example, the FocusAndSelectOnClickHandler could specify an IEventChecker as a constructor argument, which would be used to check if a given MouseEvent should enable appending to/removing from the selection, for example, by checking if a certain modifier is pressed.