Summary: | [Tooling] Graphical refresh issues when toggling the port kind | ||
---|---|---|---|
Product: | [Modeling] Papyrus-rt | Reporter: | Peter Cigehn <peter.cigehn> |
Component: | tool | Assignee: | Ansgar Radermacher <ansgar.radermacher> |
Status: | CLOSED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P3 | CC: | charles, papyrus-bugs, sredding |
Version: | 0.7.2 | Keywords: | ui |
Target Milestone: | 0.8.0 | ||
Hardware: | PC | ||
OS: | Windows 7 | ||
See Also: |
https://git.eclipse.org/r/82495 https://git.eclipse.org/c/papyrus-rt/org.eclipse.papyrus-rt.git/commit/?id=bd9a413b7282ae80168bdb5cdb35aba6119c8117 |
||
Whiteboard: |
Description
Peter Cigehn
2016-09-02 10:21:48 EDT
Confirmed still an issue. Moving to New I can now reproduce the error. I could not see it first, since the selection rectangle hides a part of the port shape - but it becomes evident at a higher zoom level. (In reply to Ansgar Radermacher from comment #2) > I can now reproduce the error. I could not see it first, since the selection > rectangle hides a part of the port shape - but it becomes evident at a > higher zoom level. Yes, make the selection of the port in the model explorer, and not in the diagram. This ensures that you see the graphical glitch more clearly. I had the "link with Editor" synchronisation active. In fact, it does not matter whether you select in diagram or model explorer, the behavior can just be seen better w/o the selection border. Btw the problem is also observable, if the port is on the top border, but to a smaller extend. A first analysis of the code shows that the problem is related to the clipping within the figure hierarchy. The class SelectableBorderedNodeFigure is a parent of the RTPortFigure. If called via the normal refresh, it has different clipping bounds compared to when the update is triggered via the port-type change: in case of the latter the clipping bounds correspond to a larger capsule (therefore no problem on the right and on the bottom). Yet the call stack seems to be identical. (In reply to Peter Cigehn from comment #3) > (In reply to Ansgar Radermacher from comment #2) > > Yes, make the selection of the port in the model explorer, and not in the > diagram. This ensures that you see the graphical glitch more clearly. (In reply to Ansgar Radermacher from comment #4) > I had the "link with Editor" synchronisation active. In fact, it does not > matter whether you select in diagram or model explorer, the behavior can > just be seen better w/o the selection border. Sorry, that was what I (implicitly) meant with selecting in the model explorer, i.e. to avoid having the selection markers on the port. I did not consider the case with "link with editor", since I normally don't use that. > Btw the problem is also observable, if the port is on the top border, but to > a smaller extend. Yes, as I indicated in Comment 0, the graphical glitch can be seen when the port is placed on the left and the top borders. It is not visible when the port is placed on the right and bottom borders. The graphical glitch is slightly different between right and top borders, since the "refresh area" seem to "cut through" the port at different positions on the left vs. top borders. New Gerrit change created: https://git.eclipse.org/r/82495 Gerrit change https://git.eclipse.org/r/82495 was merged to [master]. Commit: http://git.eclipse.org/c/papyrus-rt/org.eclipse.papyrus-rt.git/commit/?id=bd9a413b7282ae80168bdb5cdb35aba6119c8117 Fixed with gerrit merge. No need for additional handling of stacked ports, since they now fit into the normal port bounds (see fix for 500982). Do you put this one into resolved fixed, or it is something remaining to be done? Not sure if there are some suitable unit tests that can be added to avoid regressions in this area. I set to resolved (I think, it's very difficult to test whether the graphic corresponds to the expectation, but I've little experience with graphical tests). Verified to be fixed in the latest Papyrus-RT build. It is now possible to toggle the port kind (including having the port replicated showing the stacking pattern), without graphical refresh issues on any of the borders (especially the left and top border which had it before). What can be noted though is that the behavior adornment does not re-orient when moving the port to another border. This is tracked by Bug 504059. Putting into verified fixed. Closing as verified fixed. |