Summary: | tooltip should close after quickfix is applied | ||
---|---|---|---|
Product: | [ECD] Orion (Archived) | Reporter: | Carolyn MacLeod <Carolyn_MacLeod> |
Component: | Client | Assignee: | Curtis Windatt <curtis.windatt.public> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | normal | ||
Priority: | P3 | CC: | curtis.windatt.public, libingw, Michael_Rennie, Olivier_Thomann |
Version: | unspecified | Keywords: | accessibility |
Target Milestone: | 13.0 | ||
Hardware: | PC | ||
OS: | Windows 7 | ||
Whiteboard: |
Description
Carolyn MacLeod
2016-06-13 11:45:14 EDT
This problem shows up on the codeEdit demo page, so would be nice to have it fixed. http://libingw.github.io/OrionCodeEditTern/ It's worth noting this only happens for quick fixes that don't modify the editor contents. Yep - agreed. It's a special case. Unfortunately it's front-row-center in the codeEdit tooling demo. :) I'm aware that in the multi-file code edit demo it's very obvious. If needed we can modify that quick fix to touch the editor. I'm looking at whether there is a fix we can do for all quick fixes. (In reply to Curtis Windatt from comment #4) > I'm aware that in the multi-file code edit demo it's very obvious. If > needed we can modify that quick fix to touch the editor. I'm looking at > whether there is a fix we can do for all quick fixes. I don't think a good solution is to have the quickfixes work around the problem. A better fix would be to have the fix button fire an event / use a callback so the popup knows to be torn down - just like we do for the proposals popup. (In reply to Michael Rennie from comment #5) > I don't think a good solution is to have the quickfixes work around the > problem. A better fix would be to have the fix button fire an event / use a > callback so the popup knows to be torn down - just like we do for the > proposals popup. Agreed. Better to separate the tooling from the UI details. http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=78f112068abc894be1946e47cbaf0f31773371cb Fixed in master We now pass a post quickfix callback in the user data we give to the commands. When a quickfix button is activated, the callback will be called after command invocation. Currently the callback simply calls hide(), but if needed we could use this to perform additional operations (like relint the file). *** Bug 500696 has been marked as a duplicate of this bug. *** |