Bug 495132

Summary:	Completion on resource path (src/href...) in HTML editor
Product:	[WebTools] WTP Source Editing	Reporter:	Mickael Istria <mistria>
Component:	wst.html	Assignee:	Nitin Dahyabhai <thatnitind>
Status:	RESOLVED FIXED	QA Contact:	Nitin Dahyabhai <thatnitind>
Severity:	enhancement
Priority:	P1	CC:	azerr, cvgaviao, kaloyan, thatnitind
Version:	unspecified	Keywords:	plan
Target Milestone:	3.14
Hardware:	All
OS:	All
See Also:	https://git.eclipse.org/r/74205 https://git.eclipse.org/r/141362 https://git.eclipse.org/c/sourceediting/webtools.sourceediting.git/commit/?id=a83bc4718b2af67f88bfa722569d55639ded0911
Whiteboard:

Description Mickael Istria

2016-06-01 06:31:13 EDT

When triggering completion on an attribute that expects a reference to another resource, completion should provide the possible resources in the project.

So if user has project/images/myPic.jpeg and complete on project/page.html in a <img src="..."/> then they should be suggested images/myPic.jpeg.

Comment 1 Angelo ZERR

2016-06-01 06:47:01 EDT

@Mickael as you know, I have already done that with Eclipse WTP WebResources. See 

 * https://github.com/angelozerr/eclipse-wtp-webresources/wiki/Image-Features
 * https://github.com/angelozerr/eclipse-wtp-webresources/wiki/Script-Features
 * https://github.com/angelozerr/eclipse-wtp-webresources/wiki/CSS-Features#css-files-with-link

Comment 2 Eclipse Genie

2016-06-01 07:19:55 EDT

New Gerrit change created: https://git.eclipse.org/r/74205

Comment 3 Mickael Istria

2016-06-01 07:23:06 EDT

@Angelo: I took some inspiration in your work and adapted/rewrote a few basic completionProposalProviders. Currently, they're missing the preview feature for images (and even for text files). However, they seem to do the work well enough. Can you please review the PR and give it a +1 if you're fine with it, both from code and IP perspective?
I would like to include most of the features in wtp-webresources into HTML editor by Oxygen, and for the simplest and least risky ones in Neon.1.

Comment 4 Mickael Istria

2016-06-23 07:32:23 EDT

@Nitin: Can you please review the suggested patch? Would be nice to have it in master ASAP and consider backporting it for Neon.1.

Comment 5 Mickael Istria

2019-04-02 07:15:33 EDT

FWIW, Eclipse Wild Web Developer ( https://marketplace.eclipse.org/content/eclipse-wild-web-developer-web-development-eclipse-ide ) has this feature built-in.

Comment 6 Nitin Dahyabhai

2019-04-28 17:48:10 EDT

With some alterations from the original changesets, merged.

Comment 7 Eclipse Genie

2019-04-29 17:40:35 EDT

New Gerrit change created: https://git.eclipse.org/r/141362

Comment 8 Eclipse Genie

2019-04-30 08:39:13 EDT

Gerrit change https://git.eclipse.org/r/141362 was merged to [master].
Commit: http://git.eclipse.org/c/sourceediting/webtools.sourceediting.git/commit/?id=a83bc4718b2af67f88bfa722569d55639ded0911