Bug 493421

Summary:	Support for locales with country and variant code
Product:	[Modeling] ECP	Reporter:	Heiko Schaefer <schaefer.heiko>
Component:	EMF Forms	Assignee:	Eugen Neufeld <eneufeld>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	jhelming, sdirix
Version:	1.8.0	Keywords:	test
Target Milestone:	backlog
Hardware:	PC
OS:	Windows 7
See Also:	https://git.eclipse.org/r/124277 https://git.eclipse.org/c/emfclient/org.eclipse.emf.ecp.core.git/commit/?id=b7a1cd685670180761ffbdcbd837c655587030cb
Whiteboard:	stalebug

Description Heiko Schaefer

2016-05-11 08:59:55 EDT

*Overview*

The implementation EMFFormsLocalizationServiceImpl apparently does not
support country or variant codes.

*Steps to Reproduce*

1. Provide translations for german and austrian translations to your edit project.

Example for example org.eclipse.emf.ecp.makeithappen.model.edit:

plugin_de.properties:
_UI_User_type = Benutzer

plugin_de_AT.properties:
_UI_User_type = Benützer

2. Start the product with -nl de and -nl de_AT options

*Actual Results*

In both cases the german translation is used.

Example:

In both cases, the tooltip for "First Name" of the MakeItHappen ECP Sample e4 Application shows "The first name of the Benutzer".

*Expected Results*

When startet with the "-nl de_AT" option the austrian translation should be used.

Example:

When startet with the "-nl de_AT" option the tooltip for "First Name" of the MakeItHappen ECP Sample e4 Application should show "The first name of the Benützer".

Comment 1 Eugen Neufeld

2016-05-11 10:28:20 EDT

Hi Heiko, 
thank you for the report. 
I'm afraid we won't be able to fix this for the upcoming 1.9.0 release.

We are happy to accept contributions or sponsoring in order to fix this.

Cheers,
Eugen

Comment 2 Eclipse Genie

2018-05-22 11:36:19 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.

Comment 3 Eclipse Genie

2018-06-08 12:32:48 EDT

New Gerrit change created: https://git.eclipse.org/r/124277

Comment 4 Eclipse Genie

2018-06-13 09:44:58 EDT

Gerrit change https://git.eclipse.org/r/124277 was merged to [develop].
Commit: http://git.eclipse.org/c/emfclient/org.eclipse.emf.ecp.core.git/commit/?id=b7a1cd685670180761ffbdcbd837c655587030cb

Comment 5 Stefan Dirix

2018-06-13 10:33:06 EDT

TESTING INFORMATION

This bugfix potentially affects all users of EMF Forms which use a locale including country or region information.

If properties files for country and or region variants exist next to the pure language properties files and the locale is set to include the country or region, then these files will be picked up. Depending on the requirements of the user this may be a regression.

Affected are users who render forms with EMF Forms, use the default localization service of EMF Forms and have properties files for countries and or regions.

Things that shall be tested:
If your projects contain properties files for countries or regions previously unused by EMF Forms, re-run your application and check if the forms rendered by EMF Forms are still translated in the way you expect.