Bug 492601

Summary:

In pde.build tests, when delta pack is created, should not "fail on error"

Product:

[Eclipse Project] PDE

Reporter:

David Williams <david_williams>

Component:

Build

Assignee:

pde-build-inbox <pde-build-inbox>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

markus.kell.r, Vikas.Chandra

Version:

4.6

Target Milestone:

4.6 M7

Hardware:

OS:

Linux

Whiteboard:

Bug Depends on:

Bug Blocks:

492580

Attachments:

Description	Flags
patch to change "true" to "false".	none

Description David Williams

2016-04-27 16:28:10 EDT

This is related to bug 492580. I noticed that "failonError" for the p2.repoRunnable task is set to true (which, is the default). 

We should set that to "false". I suspect that is what causes the "whole test run" to exit, instead of causing some tests to fail.

Comment 1 David Williams

2016-04-27 16:30:42 EDT

Created attachment 261318 [details]
patch to change "true" to "false".

Comment 2 David Williams

2016-04-27 21:00:39 EDT

I think there is another issue with the pde build tests that is at least wrong, if not related to bug 492580. There is section of the 'init' code says:

    <delete>
      <fileset dir="${eclipse-home}" includes="org*.xml"/>
    </delete>

There is also an earlier variable that says 

<property name="eclipse-home" value="${basedir}\..\.."/>

I am pretty sure that variable setting is ignored during our tests since 'eclipse-home' should have already been set by the outer test.xml. 

In fact, the main log says, to paraphrase, 
 
.. the value of eclipse-home is /opt/users/genie.shared/workspace/ep46I-unit-lin64/workarea/I20160427-1200/eclipse-testing/test-eclipse/eclipse

So, I think that <delete> does nothing? It is not recursive, right? 
(At first, I thought it might be deleting the "artifacts.xml" file, but ... guess not since it starts with 'org'.) 

So, this comment can pretty much be ignored :) Unless someone thinks deleting things during 'init' is a bad idea like I do. But, it is not wrong as I thought at first. 

You might want to turn on "verbose", though, so we'd know for sure if it was deleting anything.

Comment 3 Vikas Chandra

2016-04-28 04:26:57 EDT

Resolved via 
http://git.eclipse.org/c/pde/eclipse.pde.build.git/commit/?id=53a4e6d1f42833a8f36e5406441a7444ae382c34

Thanks David.

Comment 4 Markus Keller

2016-04-28 05:46:47 EDT

(In reply to David Williams from comment #2)
> <property name="eclipse-home" value="${basedir}\..\.."/>
...
>     <delete>
>       <fileset dir="${eclipse-home}" includes="org*.xml"/>
>     </delete>

These things are present in all test.xml files and were used in pre-Maven times to allow running tests from your workspace, and to ensure that repeated runs produce new results each time. I don't know how much of this is still functional, but I don't see a point in messing with stuff that nobody fully understands and that doesn't hurt at all.

Comment 5 David Williams

2016-04-28 15:44:26 EDT

Verified on I20160428-0800 that the 'false' value prevented the "failure" from stopping the whole test process. 

The creation of the delta pack still failed, but, that's better than failing the whole test run! 

Thanks,