Bug 487240

Summary:	Refactor current GEF4 test base, generalizing setup and using mocking framework.
Product:	[Tools] GEF	Reporter:	Alexander Nyßen <nyssen>
Component:	Misc	Assignee:	gef-inbox <gef-inbox>
Status:	NEW ---	QA Contact:
Severity:	normal
Priority:	P3
Version:	0.2.0
Target Milestone:	---
Hardware:	All
OS:	All
Whiteboard:
Bug Depends on:	506247
Bug Blocks:

Description Alexander Nyßen

2016-02-04 09:54:26 EST

Some of the tests we currently provide within common.tests, mvc.tests, and mvc.x.tests are rather polluted with lots of boilerplate. We should externalize the setup (preparing modules, JavaFX toolkit setup) e.g. by using rules, and make use of a mocking framework to increase maintainability. 

I have created https://dev.eclipse.org/ipzilla/show_bug.cgi?id=10844 to request usage of easymock.

Comment 1 Alexander Nyßen

2016-02-05 09:26:54 EST

IPzilla has been approved, we may use easymock 2.4.

Comment 2 Alexander Nyßen

2016-10-20 00:04:03 EDT

It seems the Orbit-provided EasyMock 2.4 is not capable of partial mocking, which makes it pretty much useless in our environment. The current released 3.4 version supports this feature, but it is not provided via Orbit. 

While the Orbit-provided Mockito version 1.9.5 seems to be capable of partial mocking, a quick check let me directly run into bug #34916, so that adopting it would probably be only an option if Mockito is updated to a 2.x version (see bug #506247).

The Orbit-provided JMock version 1.2 also seems to be quite outdated (current release is 2.6.0).

It seems, the platform uses Mockito, so waiting for an update of it (see bug #506247) seems to be the best option. I will ensure the approval for easymock 2.4 is removed from our IP log.