Bug 486145

Summary: tasks should not receive incoming notifications for attributes that aren't visible
Product: z_Archived Reporter: Brandon Dong <brandon.dong>
Component: MylynAssignee: Brandon Dong <brandon.dong>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: jaxsun.mccarthy, thomas.ehrnhoefer
Version: 3.18Keywords: contributed, noteworthy
Target Milestone: 3.19   
Hardware: PC   
OS: Windows 7   
See Also: https://git.eclipse.org/r/64713
https://git.eclipse.org/c/mylyn/org.eclipse.mylyn.tasks.git/commit/?id=8902a34bff4c8a8ccf6b80ff2401f05447d8e2e6
https://git.eclipse.org/r/66872
https://git.eclipse.org/c/mylyn/org.eclipse.mylyn.tasks.git/commit/?id=dacac85a258520a69fef851ba8b62499b6744b0d
https://git.eclipse.org/r/67837
https://git.eclipse.org/c/mylyn/org.eclipse.mylyn.reviews.git/commit/?id=488e8a7b0ace8179e78cc20ff239e8792d79505d
Whiteboard:

Description Brandon Dong CLA 2016-01-19 18:39:53 EST
diff.setHasChanged in SynchronizationManger doesn't seem to be called properly.
Comment 1 Sam Davis CLA 2016-01-19 19:08:23 EST
Mylyn already has functionality to suppress incomings for attributes with no kind, but this is only enabled for connectors that contribute a SynchronizationParticipant. This functionality should always be enabled. This will mean that connectors which contribute additional task editor sections to display attributes must define their own attribute kind for those attributes so that users receive notifications in the task list when (only) those attributes have changed.

We'll need to ensure that new comments and attachments continue to result in incomings.
Comment 2 Eclipse Genie CLA 2016-01-19 20:23:32 EST
New Gerrit change created: https://git.eclipse.org/r/64713
Comment 4 Sam Davis CLA 2016-02-09 16:14:28 EST
With this change, Mylyn now suppresses notifications on changes to most attributes that have no kind. These attributes are normally not shown in the task editor unless connectors contribute custom task editor sections to display them. Such connectors should now ensure that the attributes in those sections have a kind set in the attribute metadata. Otherwise, users will not be notified when those attributes change unless other attributes (with a kind) have changed at the same time.

Previously, this behaviour only applied to connectors that contribute a SynchronizationParticipant.
Comment 5 Eclipse Genie CLA 2016-02-18 17:13:52 EST
New Gerrit change created: https://git.eclipse.org/r/66872
Comment 7 Eclipse Genie CLA 2016-03-04 17:04:41 EST
New Gerrit change created: https://git.eclipse.org/r/67837