Summary: | [typing] Spaces only mode: backspace key to remove many spaces | ||
---|---|---|---|
Product: | [Eclipse Project] Platform | Reporter: | Mateusz Matela <mateusz.matela> |
Component: | Text | Assignee: | Mateusz Matela <mateusz.matela> |
Status: | RESOLVED FIXED | QA Contact: | |
Severity: | enhancement | ||
Priority: | P3 | CC: | daniel_megert, eclipse.org, loskutov, mistria, sarika.sinha |
Version: | 4.5.1 | Keywords: | noteworthy |
Target Milestone: | 4.14 M1 | ||
Hardware: | All | ||
OS: | All | ||
See Also: |
https://git.eclipse.org/r/145561 https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=5f90916aa35368e9894d559308845c7f5c5d6a23 https://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=a03cad6f3526f31739302537a93d1b9a2d87b727 https://bugs.eclipse.org/bugs/show_bug.cgi?id=551197 https://git.eclipse.org/r/150930 https://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=f5ca55eae0cb8fb6c148541b8d46e6008155bbaf |
||
Whiteboard: | |||
Bug Depends on: | |||
Bug Blocks: | 551170 |
Description
Mateusz Matela
2015-12-07 16:11:44 EST
New Gerrit change created: https://git.eclipse.org/r/145561 Build successful :) Anyone willing to do a review? Do you require tests for this? I couldn't find any tests for preexisting related functionality that I could use as an example. And I think the feature is quite simple and easy to test manually. Andrey, maybe you can have a look? Let's make it a tentative for 4.14. (In reply to Mickael Istria from comment #4) > Let's make it a tentative for 4.14. Thanks for the feedback, I'll check it soon. Are you sure you mean 4.14 RC1? Why not sooner, like M1/M3? Unless you mean 4.13 RC1, which is still in the future? (In reply to Mateusz Matela from comment #5) > (In reply to Mickael Istria from comment #4) > > Let's make it a tentative for 4.14. > > Thanks for the feedback, I'll check it soon. > Are you sure you mean 4.14 RC1? Why not sooner, like M1/M3? > Unless you mean 4.13 RC1, which is still in the future? Sorry, I meant 4.14.M1 (opening in a couple of weeks) Gerrit change https://git.eclipse.org/r/145561 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=5f90916aa35368e9894d559308845c7f5c5d6a23 Patch merged, thanks Mateusz. Please also add a note about it in the N&N document: https://git.eclipse.org/c/www.eclipse.org/eclipse/news.git N&N added with https://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=a03cad6f3526f31739302537a93d1b9a2d87b727 Also added bug 551170 for JDT UI as the java editor overrides the installTabsToSpacesConverter() method and needs to be modified to respect the new setting. Are you aware of other projects that we might need to alert about this change? (In reply to Mateusz Matela from comment #9) > Are you aware of other projects that we might need to alert about this > change? I think CDT should also be verified. New Gerrit change created: https://git.eclipse.org/r/150930 Gerrit change https://git.eclipse.org/r/150930 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.text.git/commit/?id=f5ca55eae0cb8fb6c148541b8d46e6008155bbaf I was trying out this feature and observed that "Using Space for Tabs" and the new pref works on txt file but not on Java file. Is this expected or I should create a bug? (In reply to Sarika Sinha from comment #13) Just checked with I20200919-1800, this works when your java formatter profile has the "spaces only" tab policy. This was handled in bug 551170. (In reply to Mateusz Matela from comment #14) > (In reply to Sarika Sinha from comment #13) > > Just checked with I20200919-1800, this works when your java formatter > profile has the "spaces only" tab policy. This was handled in bug 551170. Thanks! Yes it works with the "spaces only" tab policy. One more question for java editor -> While using tab it used 4 spaces but for delete It went back 2 spaces so I had to press delete 2 times for one forward tab. Am I missing something again? (In reply to Sarika Sinha from comment #15) This feature tries to emulate the behavior of tabs where they must always end at positions divisible by 4, that probably causes the effect you see. When you press backpace/delete at position divisible by 2 but not by 4, it will remove 2 spaces. (In reply to Mateusz Matela from comment #16) > (In reply to Sarika Sinha from comment #15) > > This feature tries to emulate the behavior of tabs where they must always > end at positions divisible by 4, that probably causes the effect you see. > When you press backpace/delete at position divisible by 2 but not by 4, it > will remove 2 spaces. Ok, Makes sense. Thanks again for the clarification. (In reply to Mateusz Matela from comment #14) > (In reply to Sarika Sinha from comment #13) > > Just checked with I20200919-1800, this works when your java formatter > profile has the "spaces only" tab policy. This was handled in bug 551170. It does not work for me for C/C++ (Eclipse 4.20, CDT 10.3.0). I have "Remove multiple spaces on backspace/delete" activated (General > Editors) and also have "Tab policy: Spaces only" selected (C/C++ > Formatter). Anything else I'd have to configure for this to work? (In reply to Dan K. from comment #18) It seems we haven't notified the CTD team in the end so they probably still need to adapt to this change in a similar way that bug 551170 adapted the Java editor in JDT. Feel free to submit a bug for CDT, but maybe make sure you first check with the latest version. |