Bugzilla – Full Text Bug Listing
|
Description
Lars Vogel
Does this include removing ImageRegistry from public facing classes like AbstractUIPlugin? (In reply to Björn Arnelid from comment #1) > Does this include removing ImageRegistry from public facing classes like > AbstractUIPlugin? No New Gerrit change created: https://git.eclipse.org/r/115871 New Gerrit change created: https://git.eclipse.org/r/115872 ImageRegistry is publicly exposed in FieldDecoratingRegistry, DialogCellEditor and JFaceResources so these should probably be left as is. I think MarkerUtil is part of dead code, it should probably be removed all together? (In reply to Björn Arnelid from comment #5) > I think MarkerUtil is part of dead code, it should probably be removed all > together? For deletion of dead code, please open a new bug. I quick looks indicates that org.eclipse.ui.views.tasklist.MarkerUtil and the classes referring to it are internal and not used. If that is true, they should be deleted. New Gerrit change created: https://git.eclipse.org/r/116046 New Gerrit change created: https://git.eclipse.org/r/116045 Gerrit change https://git.eclipse.org/r/115871 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=682736e437bd8e52469e2bc67fa66aa8257e4847 Gerrit change https://git.eclipse.org/r/115872 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=730e5e415f3e02e113904431739652b88efba74a Can someone please enlighten me about what is the benefit of LocalResourceManager over ImageRegistry? I am probably not the best person to answer this since im fairly new to contributing. But one benefit i see is that it is a bit smarter when it comes to disposing resources. Instead of disposing when Display is disposed it will dispose as soon as the owner control is disposed (given that no other control claims ownership of the resource as well). (In reply to Mickael Istria from comment #11) > Can someone please enlighten me about what is the benefit of > LocalResourceManager over ImageRegistry? This would also reduce the need for activators. Activators can slow done the startup time of Eclipse. IMHO it is better to move as much as possible out of the activator. Gerrit change https://git.eclipse.org/r/116045 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.git/commit/?id=c3e4d65f779ec643b76d698ccfac77a0409714d7 New Gerrit change created: https://git.eclipse.org/r/117551 Gerrit change https://git.eclipse.org/r/117551 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=268daee9d4995a41afebfc637e47722157132682 @Björn: Anything left here? Yes, there is, ImageRegistry is fairly frequently used in platform.ui so there are a lot of places where it needs to be replaced. I will write a short comment here once i think everything is finished. Please open a new bug if you plan to continue to work on this. |