Bugzilla – Full Text Bug Listing
| Summary: | Fragment editor suggests incorrect name for inner class | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Alex Blewitt <alex.blewitt> | ||||
| Component: | UI | Assignee: | Jonas Helming <jhelming> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | jhelming, Lars.Vogel, psuzzi | ||||
| Version: | 4.5.1 | Keywords: | bugday, helpwanted | ||||
| Target Milestone: | 4.6 M3 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| See Also: |
https://git.eclipse.org/r/56322 https://git.eclipse.org/c/platform/eclipse.platform.ui.tools.git/commit/?id=020ff70cbb3243558e52b9e99da266b07398fbd8 |
||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
Gerrit reviews are welcome New Gerrit change created: https://git.eclipse.org/r/56322 Created attachment 256705 [details]
Inner class now looks picked up correctly
Outer class is now picked up together with inner class.
Gerrit change https://git.eclipse.org/r/56322 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.tools.git/commit/?id=020ff70cbb3243558e52b9e99da266b07398fbd8 patch accepted |
In the fragment.e4xmi editor, when adding an existing handler (with an associated Class URI hyperlink) with the Find button, inner classes are named incorrectly. For example: package foo; public class Outer { public static class Inner { @Execute public void doIt() { } } } Clicking on 'Find' results in a URL like: bundleclass://thebundle/foo.Inner Clearly this is going to fail at runtime. It should instead create: bundleclass://thebundle/foo.Outer$Inner It looks like it's using a combination of Package.getName() and Class.getName() which ignores any external classes.