Bugzilla – Full Text Bug Listing
| Summary: | Allow user to disable CSS styling | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Nobody - feel free to take it <nobody> | ||||
| Component: | UI | Assignee: | Nobody - feel free to take it <nobody> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | akurtakov, arunkumar.thondapu, daniel_megert, Lars.Vogel, loskutov, peter, psuzzi | ||||
| Version: | 4.6 | Keywords: | noteworthy | ||||
| Target Milestone: | 4.6 M1 | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| See Also: |
https://git.eclipse.org/r/51968 https://git.eclipse.org/r/52338 https://git.eclipse.org/r/52488 https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=500e8529b6f541fae6caf3549a95da9e67cecf7f https://git.eclipse.org/r/52883 https://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=8db3440aaba92b77bbcc70760e1236191d18fac8 https://bugs.eclipse.org/bugs/show_bug.cgi?id=516998 |
||||||
| Whiteboard: | |||||||
| Bug Depends on: | 472761 | ||||||
| Bug Blocks: | 474237, 474320, 474439, 474444, 497634, 516998, 519469 | ||||||
| Attachments: |
|
||||||
I would also expect noticable speed difference as this would reduce the calls significantly as eclipse is not going to override every color/egde/etc. independently via JNI calls. New Gerrit change created: https://git.eclipse.org/r/51968 I think such a theme should be available for all platform not only for GTK. The following command line option does this already and removes completely the CSS overhead. -cssTheme none I think the right solution is allow styling disablement via a preference setting, this will result in native rendering and a faster IDE. I adjusted the title accordingly, I hope you guys agree. (In reply to Lars Vogel from comment #3) > I think such a theme should be available for all platform not only for GTK. > > The following command line option does this already and removes completely > the CSS overhead. > > -cssTheme none > > I think the right solution is allow styling disablement via a preference > setting, this will result in native rendering and a faster IDE. I adjusted > the title accordingly, I hope you guys agree. Yep. (In reply to Lars Vogel from comment #3) > I think such a theme should be available for all platform not only for GTK. > > The following command line option does this already and removes completely > the CSS overhead. > > -cssTheme none > > I think the right solution is allow styling disablement via a preference > setting, this will result in native rendering and a faster IDE. I adjusted > the title accordingly, I hope you guys agree. The issue with that is that not having : MToolControl.Draggable { handle-image: url(./dragHandle.png); } completely disables the drag and drop. (In reply to Sopot Cela from comment #5) > The issue with that is that not having : > > MToolControl.Draggable { > handle-image: url(./dragHandle.png); > } > > completely disables the drag and drop. Sopot, I'm working since half a year with -cssTheme none and did not noticed that (and I often use drag and drop with git history view). How do you see that this is not working, what specific issue do you have? I'm on Linux GTK2/Fedora 21 if this is important. I should have been specific that it disables toolbar drag and drop. Can you confirm that you see the drag handle (the small vertical dashed line) in the toolbars (or toolcontrols such as the perspective switcher) ? (In reply to Sopot Cela from comment #7) > I should have been specific that it disables toolbar drag and drop. Can you > confirm that you see the drag handle (the small vertical dashed line) in the > toolbars (or toolcontrols such as the perspective switcher) ? A-ha. Never noticed this until now, so I've opened bug 472761. New Gerrit change created: https://git.eclipse.org/r/52338 New Gerrit change created: https://git.eclipse.org/r/52488 Gerrit change https://git.eclipse.org/r/52488 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=500e8529b6f541fae6caf3549a95da9e67cecf7f (In reply to Eclipse Genie from comment #11) > Gerrit change https://git.eclipse.org/r/52488 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/ > ?id=500e8529b6f541fae6caf3549a95da9e67cecf7f Fix merged. Will close this after I add the N&N change. (In reply to Sopot Cela from comment #12) > Fix merged. Will close this after I add the N&N change. Ping. (In reply to Lars Vogel from comment #13) > (In reply to Sopot Cela from comment #12) > > Fix merged. Will close this after I add the N&N change. > > Ping. Will do this by today for sure. New Gerrit change created: https://git.eclipse.org/r/52883 Gerrit change https://git.eclipse.org/r/52883 was merged to [master]. Commit: http://git.eclipse.org/c/www.eclipse.org/eclipse/news.git/commit/?id=8db3440aaba92b77bbcc70760e1236191d18fac8 N&N is in. There's screen cheese with disabled CSS, see bug 474320. (In reply to Dani Megert from comment #18) > There's screen cheese with disabled CSS, see bug 474320. AFAIK (I'm running without CSS long time now) this is exact only those few lines around toolbar/editor tab area, so not that serious as it sounds. (In reply to Andrey Loskutov from comment #19) > (In reply to Dani Megert from comment #18) > > There's screen cheese with disabled CSS, see bug 474320. > > AFAIK (I'm running without CSS long time now) this is exact only those few > lines around toolbar/editor tab area, so not that serious as it sounds. Right, not serious, but ugly ;-). (In reply to Dani Megert from comment #20) > (In reply to Andrey Loskutov from comment #19) > > (In reply to Dani Megert from comment #18) > > > There's screen cheese with disabled CSS, see bug 474320. > > > > AFAIK (I'm running without CSS long time now) this is exact only those few > > lines around toolbar/editor tab area, so not that serious as it sounds. > > Right, not serious, but ugly ;-). And now more widely visible, since the user can disable it via UI and since this will be mentioned in the M1 N&N. This fix causes a regression of e4 related styling in e4 RCP applications. See Bug 516998. |
Created attachment 255206 [details] Proposed look I think it would be nice for people to have the option of having Eclipse look just like any other GTK application. It's relatively small effort on our side to offer this to users. It would consist of only extremely minor adjustments and look like the attachment. I can imagine lots of people wanting a back to basic looks (no round edges etc. etc.).