Bug 467182

Summary:

Allow to implement a Compare editor without extending ContentMergeViewer

Product:

[Eclipse Project] Platform

Reporter:

Filippo Rossoni <filippo.rossoni>

Component:

Compare

Assignee:

Filippo Rossoni <filippo.rossoni>

Status:

ASSIGNED ---

QA Contact:

Severity:

enhancement

Priority:

CC:

daniel_megert, filippo.rossoni, psuzzi, sptaszkiewicz

Version:

4.5

Keywords:

api, investigate

Target Milestone:

---

Hardware:

All

OS:

All

See Also:

https://git.eclipse.org/r/47771

Whiteboard:

Attachments:

Description	Flags
Sample Project	none

Description Filippo Rossoni

2015-05-13 04:52:47 EDT

I want implement a new Compare view
if I don't extends org.eclipse.compare.contentmergeviewer.ContentMergeViewer
I can't manage dirty state for left & right separately

with patch https://git.eclipse.org/r/#/c/47771
its possible

to receive the save notification I also require org.eclipse.compare.internal.IFlushable2 as api
I didn't receive call on org.eclipse.compare.contentmergeviewer.IFlushable

Comment 1 Dani Megert

2015-05-13 05:28:46 EDT

Please provide an example that shows why the new APIs are needed and how they are used.

Comment 2 Filippo Rossoni

2015-05-13 06:34:02 EDT

Created attachment 253435 [details]
Sample Project

Comment 3 Filippo Rossoni

2015-05-13 06:45:21 EDT

Launch eclipse with Sample project plugin
compare 2 file and choose Text Merge

click edit left old 
save editor

2 message dialog save left and save right from IFlushable2 (non api)

expected:
message dialog saveAll from IFlushable


new feature
compare 2 file and choose Text Merge

click edit left and 
save only save left dialog show;

click edit left and 
close editor message show  only left file

Comment 4 Dani Megert

2015-05-13 08:51:50 EDT

We will look at this during Neon (4.6), starting in June.

Comment 5 Filippo Rossoni

2016-03-02 16:51:24 EST

any news?

Comment 6 Dani Megert

2016-03-03 03:27:02 EST

(In reply to Filippo Rossoni from comment #5)
> any news?

Sorry, no time so far.

Comment 7 Dani Megert

2017-04-12 10:42:47 EDT

Sorry, everyone is busy with other stuff.