Summary: | Broken classfile generated for incorrect annotation usage - case 2 | ||||||
---|---|---|---|---|---|---|---|
Product: | [Eclipse Project] JDT | Reporter: | Andrew Clement <aclement> | ||||
Component: | Core | Assignee: | Olivier Thomann <Olivier_Thomann> | ||||
Status: | VERIFIED FIXED | QA Contact: | |||||
Severity: | normal | ||||||
Priority: | P3 | CC: | daniel_megert, jarthana, manoj.palat, Olivier_Thomann, sasikanth.bharadwaj | ||||
Version: | 4.5 | Flags: | sasikanth.bharadwaj:
review+
|
||||
Target Milestone: | 4.5 M6 | ||||||
Hardware: | PC | ||||||
OS: | Mac OS X | ||||||
Whiteboard: | |||||||
Bug Depends on: | |||||||
Bug Blocks: | 455608 | ||||||
Attachments: |
|
Description
Andrew Clement
2015-01-07 14:18:30 EST
Thanks for the report and analysis, Andrew. Sasi, please take a look. Jay, I can take care of this one as I did the fix that is mentioned in comment 0. Right now the code tries to remove just the annotation's value as it is invalid. As this seems to cause problem, the best solution is to remove the annotation all together. Fix to follow. Created attachment 249792 [details]
Proposed patch including a regression test
Thanks for the patch, Olivier! Sasi, please review and release this patch. Sasi, this one slipped through. Please take this up once M5 is out. Patch looks good to me. All tests pass with the patch. Released via http://git.eclipse.org/c/jdt/eclipse.jdt.core.git/commit/?id=51d45c360e379dc3d174cfefd6624f6613e9055b Verified for Eclipse Mars 4.5 M6 Build id: I20150317-2000 |