Bug 442747

Summary:	Deprecate outdated CellModifier API of ColumnViewer
Product:	[Eclipse Project] Platform	Reporter:	Simon Scholz <simon.scholz>
Component:	UI	Assignee:	Simon Scholz <simon.scholz>
Status:	RESOLVED WORKSFORME	QA Contact:
Severity:	minor
Priority:	P3	CC:	daniel_megert, Lars.Vogel
Version:	4.4
Target Milestone:	---
Hardware:	PC
OS:	All
Whiteboard:
Bug Depends on:	448143
Bug Blocks:

Description Simon Scholz

2014-08-27 19:34:41 EDT

In my opinion the following three methods of the ColumnViewer should be deprecated, as the JavaDoc of those methods already states that the ViewerColumn´s EditingSupport is more flexible and therefore better.

-org.eclipse.jface.viewers.ColumnViewer.setCellEditors(CellEditor[])
-org.eclipse.jface.viewers.ColumnViewer.setCellModifier(ICellModifier)
-org.eclipse.jface.viewers.ColumnViewer.setColumnProperties(String[])

When deprecating those methods, also the ICellModifier interface can be deprecated.

Comment 1 Lars Vogel

2014-08-28 07:59:11 EDT

+1 for the change, please provide a Gerrit review for it.

Comment 2 Simon Scholz

2014-09-23 15:02:00 EDT

See patch https://git.eclipse.org/r/#/c/33793/3

Also moved "old" cell editor EditingSupport to the DefaultColumnViewerEditingSupport class, so that there is less deprecated code in the ColumnViewers class.

Comment 3 Lars Vogel

2014-09-23 15:03:41 EDT

We set a bug to Fixed once the patch is applied.

Comment 4 Lars Vogel

2014-10-01 12:27:21 EDT

At the moment platform.ui, PDE (and potentially JDT) is still using the old API. If we want to deprecate this, we need to remove this usage. Simon, please create new bug reports for this adjustment and mark this bug as dependent on this changes.

Comment 5 Lars Vogel

2014-10-20 17:23:16 EDT

(In reply to Lars Vogel from comment #4)
> If we want to deprecate this, we need to remove this usage. Simon,
> please create new bug reports for this adjustment and mark this bug as
> dependent on this changes.

Any update on the new bug report for the remove of the usage of the old API? We should start in platform.ui.

Comment 6 Lars Vogel

2015-09-25 12:38:02 EDT

(In reply to Lars Vogel from comment #5)
> Any update on the new bug report for the remove of the usage of the old API?
> We should start in platform.ui.

Ping?

Comment 7 Lars Vogel

2019-09-05 04:20:15 EDT

No feedback