Bug 43569

Summary: generate setter should declare parameter final
Product: [Eclipse Project] JDT Reporter: Nikolay Metchev <nikolaymetchev>
Component: UIAssignee: JDT-UI-Inbox <jdt-ui-inbox>
Status: RESOLVED DUPLICATE QA Contact:
Severity: normal    
Priority: P3    
Version: 3.0   
Target Milestone: ---   
Hardware: PC   
OS: Windows 2000   
Whiteboard:

Description Nikolay Metchev CLA 2003-09-24 10:17:08 EDT
When you generate a setter for a field the parameter to the setter should be 
final e.g:

----------------
public class A
{
   int m_field; //<-- generate getter for m_field
}
------------------
result should be:
--------------------
public class A
{
   int m_field; //<-- generate getter for m_field
   
   public void setField(final int field)
   {
      m_field = field;
   }
}
Comment 1 Dani Megert CLA 2003-09-24 11:32:48 EDT
I'd rather say this is a personal preference. Some people always use final when
declaring method parameters and others don't.
Comment 2 Nikolay Metchev CLA 2003-09-24 11:43:17 EDT
The best place for that preference would be in the dialog that pops up when you 
select generate getter and setter!
Comment 3 Dirk Baeumer CLA 2003-09-24 13:03:21 EDT

*** This bug has been marked as a duplicate of 40078 ***