Bug 433719

Summary: [api] Request for AbstractRepositoryConnector.getBrowserUrl()
Product: z_Archived Reporter: Leo Dos Santos <leo.dos.santos>
Component: MylynAssignee: Leo Dos Santos <leo.dos.santos>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: steffen.pingel
Version: unspecifiedKeywords: contributed, noteworthy
Target Milestone: 3.12   
Hardware: Macintosh   
OS: Mac OS X   
Whiteboard:

Description Leo Dos Santos CLA 2014-04-28 19:51:53 EDT 
In practice, some connectors have been using IRepositoryElement.getUrl or AbstractRepositoryConnector.getTaskUrl to reference a stable, non-browseable identifier or URI. Unfortunately the framework will try to surface these identifiers in places such as commit message or task details. There is a need for some connectors to be able to give both a stable URI and browseable URL (whether the latter is stable or not). Unfortunately, AbstractRepositoryConnector.getAutheticatedUrl may not suffice for such a use given that it expects to have authentication information we do not want to include as part of a commit message (ie session token). Therefore, in order to maintain compatibility with existing connectors, I propose adding a 3rd method to AbstractRepositoryConnector, getBrowseableUrl() that returns a true, browseable web URL that contains no authentication information.
Comment 1 Leo Dos Santos CLA 2014-04-28 21:01:54 EDT 
Proposal:

25698: 433719: Request for AbstractRepositoryConnector.getBrowseableUrl() [I34eeba69]
https://git.eclipse.org/r/#/c/25698/

25699: 433719: Request for AbstractRepositoryConnector.getBrowseableUrl() [I8b19972e]
https://git.eclipse.org/r/#/c/25699/
Comment 2 Sam Davis CLA 2014-04-28 21:17:37 EDT 
+1. We should consider other names as well: getOpenableUrl, getLocationUrl
Comment 3 Sam Davis CLA 2014-05-02 13:18:56 EDT 
We have settled on getBrowserUrl as best conveying the purpose of the method.
Comment 4 Sam Davis CLA 2014-05-07 19:35:57 EDT 
The changes have been merged.