Bug 432490

Summary:	Provide a way to start with GTK 3 newer than 3.9
Product:	[Eclipse Project] Equinox	Reporter:	Alexander Kurtakov <akurtakov>
Component:	Launcher	Assignee:	Arun Thondapu <arunkumar.thondapu>
Status:	VERIFIED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	arunkumar.thondapu, snjezana.peco
Version:	unspecified
Target Milestone:	Luna M7
Hardware:	PC
OS:	Linux
Whiteboard:

Description Alexander Kurtakov

2014-04-10 05:09:33 EDT

Currently the code is checking whether SWT_GTK3 is not set and whether it's set to "1". The later check should not be there as that way it's not easy to start eclipse with gtk 3.9+ and people that set their SWT_GTK3 env variable themself are supposed to know what they do.

Comment 1 Alexander Kurtakov

2014-04-10 05:13:00 EDT

Patch: https://git.eclipse.org/r/#/c/24771/

Comment 2 Arun Thondapu

2014-04-27 15:46:14 EDT

(In reply to Alexander Kurtakov from comment #1)
> Patch: https://git.eclipse.org/r/#/c/24771/

This patch will not work, instead it will end up always loading GTK2 when SWT_GTK3 is set (whatever be its value).

I have pushed another patch and rebuilt the launchers:

https://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/?id=d21b42e0a1e76dc155cef0d7031856a819171ed5

https://git.eclipse.org/c/equinox/rt.equinox.framework.git/commit/?id=6b09ecff786fa3c9f7e970b90562a23e201609a9

https://git.eclipse.org/c/equinox/rt.equinox.binaries.git/commit/?id=f4fe618cf81ecab832dd37b4adcf913afb6e8568

Comment 3 Arun Thondapu

2014-04-27 15:56:14 EDT

*** Bug 432331 has been marked as a duplicate of this bug. ***