Bug 429082

Summary: Test that ico in windows exe are replaceable
Product: [Eclipse Project] Platform Reporter: David Williams <david_williams>
Component: RelengAssignee: Platform-Releng-Inbox <platform-releng-inbox>
Status: NEW --- QA Contact:
Severity: enhancement    
Priority: P3    
Version: 4.4   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:
Bug Depends on: 433094    
Bug Blocks:    

Description David Williams CLA 2014-02-25 14:41:14 EST
While working on the new icons for bug 426260, I noticed that the old icon (eclipse.ico) could be "replaced" by the new icon in Tycho builds ... but only for the "Eclipse SDK" ... the binary platform and platform SDK could not be "replaced" and would retain the old one. 

As noted in bug 427384 the whole "replace icons" function depends on the new icon being "the same shape" as the old icon. So, I'm thinking, somehow, that in the old versions the icons in "platform" and "platform sdk" were somehow, some way, different than what was in the "Eclipse SDK" executable. That ... or, there's some other bug. 

Now, since the eclipse.exe was re-built with new icon, it is correct in all all distributions, but thought I should open this bug to sometime confirm/test the new icon can be replaced in all distributions. 

What ever test icon that's used, should have same shape as the current (new) one: 

$ icotool -l ./rt.equinox.framework/features/org.eclipse.equinox.executable.feature/library/win32/eclipse.ico
--icon --index=1 --width=48 --height=48 --bit-depth=8 --palette-size=256
--icon --index=2 --width=32 --height=32 --bit-depth=8 --palette-size=256
--icon --index=3 --width=16 --height=16 --bit-depth=8 --palette-size=256
--icon --index=4 --width=48 --height=48 --bit-depth=32 --palette-size=0
--icon --index=5 --width=32 --height=32 --bit-depth=32 --palette-size=0
--icon --index=6 --width=16 --height=16 --bit-depth=32 --palette-size=0
--icon --index=7 --width=256 --height=256 --bit-depth=32 --palette-size=0